AnarchistGamers/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-09-24 20:31:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't create unneeded filters in getMatchingUniquesWithNonLocalEffects - see #6695

Browse Source
This commit is contained in:
Yair Morgenstern 2022-05-04 22:59:14 +03:00
parent 6812caf3b3
commit 20d580976d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/com/unciv/logic/city/CityInfo.kt
View File

@ -889,9 +889,10 @@ class CityInfo {
fun getMatchingUniquesWithNonLocalEffects(uniqueType: UniqueType, stateForConditionals: StateForConditionals): Sequence<Unique> {
return cityConstructions.builtBuildingUniqueMap.getUniques(uniqueType)
.filter { !it.isLocalEffect && it.conditionalsApply(stateForConditionals) }
// Note that we don't query religion here, as those only have local effects
val uniques = cityConstructions.builtBuildingUniqueMap.getUniques(uniqueType)
// Memory performance showed that this function was very memory intensive, thus we only create the filter if needed
return if (uniques.any()) uniques.filter { !it.isLocalEffect && it.conditionalsApply(stateForConditionals) }
else uniques
}
//endregion