From 2c47d791ed7343036bba70421364fcfb56a06077 Mon Sep 17 00:00:00 2001 From: yairm210 Date: Thu, 28 Nov 2024 21:54:47 +0200 Subject: [PATCH] Allow unit triggers to be used in unit-triggered events --- .../models/ruleset/unique/UniqueTriggerActivation.kt | 6 ++---- core/src/com/unciv/models/ruleset/unique/UniqueType.kt | 10 ---------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/core/src/com/unciv/models/ruleset/unique/UniqueTriggerActivation.kt b/core/src/com/unciv/models/ruleset/unique/UniqueTriggerActivation.kt index b45bbf66bc..b4235ae2a5 100644 --- a/core/src/com/unciv/models/ruleset/unique/UniqueTriggerActivation.kt +++ b/core/src/com/unciv/models/ruleset/unique/UniqueTriggerActivation.kt @@ -124,11 +124,9 @@ object UniqueTriggerActivation { choice.triggerChoice(civInfo, unit) } if (event.presentation == Event.Presentation.Alert) return { - /** See [AlertPopup.addEvent] for the deserializing of this string to the context */ + /** See [com.unciv.ui.screens.worldscreen.AlertPopup.addEvent] for the deserializing of this string to the context */ var eventText = event.name - // Todo later version: Uncomment this to enable events with unit triggers - // if (unit != null) eventText += Constants.stringSplitCharacter + "unitId=" + unit.id - + if (unit != null) eventText += Constants.stringSplitCharacter + "unitId=" + unit.id civInfo.popupAlerts.add(PopupAlert(AlertType.Event, eventText)) true } diff --git a/core/src/com/unciv/models/ruleset/unique/UniqueType.kt b/core/src/com/unciv/models/ruleset/unique/UniqueType.kt index d8406dfa95..ed4ac3799c 100644 --- a/core/src/com/unciv/models/ruleset/unique/UniqueType.kt +++ b/core/src/com/unciv/models/ruleset/unique/UniqueType.kt @@ -844,28 +844,18 @@ enum class UniqueType( ///////////////////////////////////////// region 09 UNIT TRIGGERABLES ///////////////////////////////////////// OneTimeUnitHeal("[unitTriggerTarget] heals [positiveAmount] HP", UniqueTarget.UnitTriggerable), - OneTimeUnitDamage("[unitTriggerTarget] takes [positiveAmount] damage", UniqueTarget.UnitTriggerable), - OneTimeUnitGainXP("[unitTriggerTarget] gains [amount] XP", UniqueTarget.UnitTriggerable), - OneTimeUnitUpgrade("[unitTriggerTarget] upgrades for free", UniqueTarget.UnitTriggerable), - OneTimeUnitSpecialUpgrade("[unitTriggerTarget] upgrades for free including special upgrades", UniqueTarget.UnitTriggerable), - OneTimeUnitGainPromotion("[unitTriggerTarget] gains the [promotion] promotion", UniqueTarget.UnitTriggerable), - OneTimeUnitRemovePromotion("[unitTriggerTarget] loses the [promotion] promotion", UniqueTarget.UnitTriggerable), - OneTimeUnitGainMovement("[unitTriggerTarget] gains [amount] movement", UniqueTarget.UnitTriggerable), - OneTimeUnitLoseMovement("[unitTriggerTarget] loses [amount] movement", UniqueTarget.UnitTriggerable), - OneTimeUnitGainStatus("[unitTriggerTarget] gains the [promotion] status for [positiveAmount] turn(s)", UniqueTarget.UnitTriggerable, docDescription = "Statuses are temporary promotions. They do not stack, and reapplying a specific status take the highest number - so reapplying a 3-turn on a 1-turn makes it 3, but doing the opposite will have no effect. " + "Turns left on the status decrease at the *start of turn*, so bonuses applied for 1 turn are stll applied during other civ's turns."), OneTimeUnitLoseStatus("[unitTriggerTarget] loses the [promotion] status", UniqueTarget.UnitTriggerable), - OneTimeUnitDestroyed("[unitTriggerTarget] is destroyed", UniqueTarget.UnitTriggerable), //endregion