From 65b96d16cea0c168e674fb0afe3b12747d1143b2 Mon Sep 17 00:00:00 2001 From: yairm210 Date: Tue, 29 Oct 2024 15:22:40 +0200 Subject: [PATCH] perf(memory): Don't even create the data classes for intermediates :) --- .../logic/automation/civilization/NextTurnAutomation.kt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/com/unciv/logic/automation/civilization/NextTurnAutomation.kt b/core/src/com/unciv/logic/automation/civilization/NextTurnAutomation.kt index 39eee74b77..77ea3cad78 100644 --- a/core/src/com/unciv/logic/automation/civilization/NextTurnAutomation.kt +++ b/core/src/com/unciv/logic/automation/civilization/NextTurnAutomation.kt @@ -652,10 +652,9 @@ object NextTurnAutomation { for (civ1city in civ1.cities) for (civ2city in civ2.cities){ - val currentDistance = CityDistance(civ1city, civ2city, - civ1city.getCenterTile().aerialDistanceTo(civ2city.getCenterTile())) - if (minDistance == null || currentDistance.aerialDistance < minDistance.aerialDistance) - minDistance = currentDistance + val currentDistance = civ1city.getCenterTile().aerialDistanceTo(civ2city.getCenterTile()) + if (minDistance == null || currentDistance < minDistance.aerialDistance) + minDistance = CityDistance(civ1city, civ2city, currentDistance) } return minDistance