AnarchistGamers/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-09-22 10:54:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Warn of rendering performance problems for split atlases

Browse Source
This commit is contained in:
yairm210 2025-05-27 07:50:04 +03:00
parent f0bd3cbb4e
commit a11c3c4216
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt
View File

@ -129,6 +129,7 @@ class RulesetValidator(val ruleset: Ruleset) {
checkMisspelledFolders(folder, lines) checkMisspelledFolders(folder, lines)
checkImagesFolders(folder, lines) checkImagesFolders(folder, lines)
checkUnknownJsonFilenames(folder, lines) checkUnknownJsonFilenames(folder, lines)
warnSplitAtlasesPerformanceDegradation(folder, lines)
} }
private fun checkMisspelledFolders( private fun checkMisspelledFolders(
@ -193,18 +194,31 @@ class RulesetValidator(val ruleset: Ruleset) {
) { ) {
val jsonFolder = folder.child("jsons") val jsonFolder = folder.child("jsons")
if (!jsonFolder.exists()) return if (!jsonFolder.exists()) return
for (file in jsonFolder.list("json")) { for (file in jsonFolder.list("json")) {
if (file.name() in RulesetFile.entries.map { it.filename }) continue if (file.name() in RulesetFile.entries.map { it.filename }) continue
var text = "File ${file.name()} is in the jsons folder but is not a recognized ruleset file" var text = "File ${file.name()} is in the jsons folder but is not a recognized ruleset file"
val possibleMisspellings = getPossibleMisspellings(file.name(), RulesetFile.entries.map { it.filename }) val possibleMisspellings = getPossibleMisspellings(file.name(), RulesetFile.entries.map { it.filename })
if (possibleMisspellings.isNotEmpty()) if (possibleMisspellings.isNotEmpty())
text += "\nPossible misspelling of: " + possibleMisspellings.joinToString("/") text += "\nPossible misspelling of: " + possibleMisspellings.joinToString("/")
lines.add(text, RulesetErrorSeverity.OK) lines.add(text, RulesetErrorSeverity.OK)
} }
} }
private fun warnSplitAtlasesPerformanceDegradation(
folder: FileHandle,
lines: RulesetErrorList
) {
if (folder.child("game2.png").exists()){
lines.add(
"Your images are being generated into multiple atlas files - this can cause lag for players. " +
"Please consult https://yairm210.github.io/Unciv/Modders/Images-and-Audio/#rendering-performance on how to improve rendering performance.",
RulesetErrorSeverity.WarningOptionsOnly, sourceObject = null
)
}
}
private fun addModOptionsErrors(lines: RulesetErrorList, tryFixUnknownUniques: Boolean) { private fun addModOptionsErrors(lines: RulesetErrorList, tryFixUnknownUniques: Boolean) {
// Basic Unique validation (type, target, parameters) should always run. // Basic Unique validation (type, target, parameters) should always run.