Upgrade actions checkout from v3 to v4 to avoid 'node 16 actions deprecated' warnings

.github/workflows/buildAndDeploy.yml

@@ -20,7 +20,7 @@ jobs:
       release_body: ${{ steps.read_release.outputs.release_body }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Read release.md and use it as a body of new release. This will fail for patch releases, since they have no readme.
         continue-on-error: true
@@ -45,7 +45,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: get-release-body
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:
@@ -107,7 +107,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: get-release-body
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:
@@ -178,7 +178,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: build-jar
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:

.github/workflows/buildAndTest.yml

@@ -14,7 +14,7 @@ jobs:
     name: Check code and run unit tests
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:

.github/workflows/buildMultiplatform.yml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Build Android (Java ${{ matrix.java_version }})
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:
@@ -72,7 +72,7 @@ jobs:
 
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-java@v3
         with:

.github/workflows/detektAnalysis.yml

@@ -17,7 +17,7 @@ jobs:
 
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Set up JDK
       uses: actions/setup-java@v2

.github/workflows/dockerPublish.yml

@@ -30,7 +30,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       # Install the cosign tool except on PR
       # https://github.com/sigstore/cosign-installer

.github/workflows/mkdocs.yml

@@ -8,7 +8,7 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-python@v2
         with:
           python-version: 3.x

.github/workflows/uncivbot.yml

@@ -11,7 +11,7 @@ jobs:
     # This is the only place I could find an apparent list of valid author associations. Also, at least they're not case-sensitive: https://docs.github.com/en/graphql/reference/enums#commentauthorassociation https://docs.github.com/en/actions/learn-github-actions/expressions#contains
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v2
       - name: Generate new buildConfig.kt and changelog.md files
         run: |
@@ -53,7 +53,7 @@ jobs:
               repo: repository.repo,
             })
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with: # Required for triggering the deploy on tags added by this automation
           # See https://github.com/stefanzweifel/git-auto-commit-action#commits-made-by-this-action-do-not-trigger-new-workflow-runs
           token: ${{ secrets.ACTIONS_ACCESS_TOKEN }}
@@ -76,7 +76,7 @@ jobs:
     # This is the only place I could find an apparent list of valid author associations. Also, at least they're not case-sensitive: https://docs.github.com/en/graphql/reference/enums#commentauthorassociation https://docs.github.com/en/actions/learn-github-actions/expressions#contains
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v2
       - name: Add translation PRs to the new branch, and PR the new branch to master
 

core/src/com/unciv/logic/BackwardCompatibility.kt

@@ -201,7 +201,7 @@ object BackwardCompatibility {
         historyStartTurn = turns
     }
 
-    fun GameInfo.ensureUnitIds(){
+    fun GameInfo.ensureUnitIds() {
         if (lastUnitId == 0) lastUnitId = tileMap.values.asSequence()
             .flatMap { it.getUnits() }.maxOfOrNull { it.id }?.coerceAtLeast(0) ?: 0
         for (unit in tileMap.values.flatMap { it.getUnits() }) {