From d5dffa928a678a83b4a6ef5f5ce19474c834fe95 Mon Sep 17 00:00:00 2001
From: Yair Morgenstern <yairm210@hotmail.com>
Date: Tue, 26 Sep 2023 16:46:05 +0300
Subject: [PATCH] performance: #10173 - Only check promotion circular
 references once, not once per promotion

---
 .../src/com/unciv/models/ruleset/validation/RulesetValidator.kt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt b/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt
index 26b4ea9e8f..1d8e495221 100644
--- a/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt
+++ b/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt
@@ -374,8 +374,8 @@ class RulesetValidator(val ruleset: Ruleset) {
                     RulesetErrorSeverity.Warning)
             }
             checkUniques(promotion, lines, rulesetSpecific, tryFixUnknownUniques)
-            checkPromotionCircularReferences(lines)
         }
+        checkPromotionCircularReferences(lines)
 
         for (unitType in ruleset.unitTypes.values) {
             checkUniques(unitType, lines, rulesetSpecific, tryFixUnknownUniques)