From d62408fd31ddd9e91096683ba11f5a9c3bed7ee3 Mon Sep 17 00:00:00 2001 From: Yair Morgenstern Date: Tue, 26 Sep 2023 14:56:40 +0300 Subject: [PATCH] performance: Only build strings in ruleset validation when necessary --- .../com/unciv/models/ruleset/validation/RulesetValidator.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt b/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt index 7ba14f0333..cb9b6a1833 100644 --- a/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt +++ b/core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt @@ -635,8 +635,8 @@ class RulesetValidator(val ruleset: Ruleset) { namedObj: INamed?, severityToReport: UniqueType.UniqueComplianceErrorSeverity ): List { - val prefix = (if (namedObj is IRulesetObject) "${namedObj.originRuleset}: " else "") + - (if (namedObj == null) "The" else "${namedObj.name}'s") + val prefix by lazy { (if (namedObj is IRulesetObject) "${namedObj.originRuleset}: " else "") + + (if (namedObj == null) "The" else "${namedObj.name}'s") } if (unique.type == null) return checkUntypedUnique(unique, tryFixUnknownUniques, prefix) val rulesetErrors = RulesetErrorList()