From 899c302b14691e9bfe2132cba09aa5449b6f3b58 Mon Sep 17 00:00:00 2001 From: elsid Date: Wed, 8 Mar 2023 01:10:12 +0100 Subject: [PATCH] Avoid nested ifs --- apps/opencs/model/world/idtable.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/opencs/model/world/idtable.cpp b/apps/opencs/model/world/idtable.cpp index 8d2e676725..4ec9c301f1 100644 --- a/apps/opencs/model/world/idtable.cpp +++ b/apps/opencs/model/world/idtable.cpp @@ -298,10 +298,12 @@ int CSMWorld::IdTable::findColumnIndex(Columns::ColumnId id) const void CSMWorld::IdTable::reorderRows(int baseIndex, const std::vector& newOrder) { - if (!newOrder.empty()) - if (mIdCollection->reorderRows(baseIndex, newOrder)) - emit dataChanged(index(baseIndex, 0), - index(baseIndex + static_cast(newOrder.size()) - 1, mIdCollection->getColumns() - 1)); + if (newOrder.empty()) + return; + if (!mIdCollection->reorderRows(baseIndex, newOrder)) + return; + emit dataChanged( + index(baseIndex, 0), index(baseIndex + static_cast(newOrder.size()) - 1, mIdCollection->getColumns() - 1)); } std::pair CSMWorld::IdTable::view(int row) const