From 9d63c34c470a908fa9323d1e33b0fb8b22c2160b Mon Sep 17 00:00:00 2001 From: Evil Eye Date: Sat, 23 Aug 2025 11:00:49 +0200 Subject: [PATCH] Reuse quest name --- apps/openmw/mwgui/journalviewmodel.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/openmw/mwgui/journalviewmodel.cpp b/apps/openmw/mwgui/journalviewmodel.cpp index 626d423fd4..8c47edc9ea 100644 --- a/apps/openmw/mwgui/journalviewmodel.cpp +++ b/apps/openmw/mwgui/journalviewmodel.cpp @@ -205,21 +205,21 @@ namespace MWGui // Unfortunately Morrowind.esm has no quest names, since the quest book was added with tribunal. // Note that even with Tribunal, some quests still don't have quest names. I'm assuming those are not // supposed to appear in the quest book. - if (quest.getName().empty()) + const std::string_view questName = quest.getName(); + if (questName.empty()) continue; // Don't list the same quest name twice - if (!visitedQuests.insert(quest.getName()).second) + if (!visitedQuests.insert(questName).second) continue; bool isFinished = std::ranges::find_if(journal->getQuests(), [&](const auto& pair) { - return pair.second.isFinished() - && Misc::StringUtils::ciEqual(quest.getName(), pair.second.getName()); + return pair.second.isFinished() && Misc::StringUtils::ciEqual(questName, pair.second.getName()); }) != journal->getQuests().end(); if (activeOnly && isFinished) continue; - visitor(quest.getName(), isFinished); + visitor(questName, isFinished); } }