AnarchistGamers/openmw
1
0
Fork 0
mirror of https://gitlab.com/OpenMW/openmw.git synced 2025-09-10 21:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Disallow to call ESMWriter::writeT with pointer type

Browse Source 
This will make ESMWriter to use a pointer to this pointer to access the data
that is unlikely an intent. For example:
68ef96410cb6731131a82b6b0583ac30e6ffd9fc.
This commit is contained in:
elsid 2022-01-30 14:04:12 +01:00
parent 4554a075e7
commit b17c9a22ff
No known key found for this signature in database
GPG Key ID: B845CB9FEE18AB40
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
components/esm3/esmwriter.hpp
View File

@ -3,6 +3,7 @@
#include <iosfwd> #include <iosfwd>
#include <list> #include <list>
#include <type_traits>
#include "components/esm/esmcommon.hpp" #include "components/esm/esmcommon.hpp"
#include "loadtes3.hpp" #include "loadtes3.hpp"
@ -111,6 +112,7 @@ class ESMWriter
template<typename T> template<typename T>
void writeT(const T& data) void writeT(const T& data)
{ {
static_assert(!std::is_pointer_v<T>);
write((char*)&data, sizeof(T)); write((char*)&data, sizeof(T));
} }
@ -123,6 +125,7 @@ class ESMWriter
template<typename T> template<typename T>
void writeT(const T& data, size_t size) void writeT(const T& data, size_t size)
{ {
static_assert(!std::is_pointer_v<T>);
write((char*)&data, size); write((char*)&data, size);
} }