AstralTransRocketries/ClassiCube
1
0
Fork 0
mirror of https://github.com/ClassiCube/ClassiCube.git synced 2025-09-13 09:35:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix stack overflow happening when the game fails to create the logs directory (Thanks Fantasy)

Browse Source 
This was particularly annoying, because the game would immediately just close without showing the usual crash message box
This commit is contained in:
UnknownShadow200 2020-12-12 11:29:43 +11:00
parent de98806ead
commit 2e3a2ed08c
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/Chat.c
View File

@ -108,10 +108,34 @@ void Chat_DisableLogging(void) {
CloseLogFile();
}
static cc_bool CreateLogsDirectory(void) {
static const cc_string dir = String_FromConst("logs");
cc_result res;
/* Utils_EnsureDirectory cannot be used here because it causes a stack overflow */
/* when running the game and an error occurs when trying to create the directory */
/* This happens because when running the game, Logger_WarnFunc is changed to log
/* a message in chat instead of showing a dialog box, which causes the following
/* functions to be called in a recursive loop: */
/* */
/* Utils_EnsureDirectory --> Logger_SysWarn2 --> Chat_Add --> AppendChatLog -> OpenChatLog */
/* --> Utils_EnsureDirectory --> Logger_SysWarn2 --> Chat_Add --> AppendChatLog -> OpenChatLog */
/* --> Utils_EnsureDirectory --> Logger_SysWarn2 --> Chat_Add --> AppendChatLog -> OpenChatLog */
/* --> Utils_EnsureDirectory --> Logger_SysWarn2 --> Chat_Add --> AppendChatLog ... */
/* and so on, until eventually the stack overflows */
if (Directory_Exists(&dir)) return true;
res = Directory_Create(&dir);
if (!res) return true;
Chat_DisableLogging();
Logger_SysWarn2(res, "creating directory", &dir);
return false;
}
static void OpenChatLog(struct DateTime* now) {
cc_result res;
int i;
if (!Utils_EnsureDirectory("logs")) { Chat_DisableLogging(); return; }
if (!CreateLogsDirectory()) return;
/* Ensure multiple instances do not end up overwriting each other's log entries. */
for (i = 0; i < 20; i++) {