AstralTransRocketries/Cubyz
1
0
Fork 0
mirror of https://github.com/PixelGuys/Cubyz.git synced 2025-09-10 04:41:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak when a parent of a sub biome couldn't be found

Browse Source
This commit is contained in:
IntegratedQuantum 2025-01-08 22:43:03 +01:00
parent 4992176274
commit 71e0554ed2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/server/terrain/biomes.zig
View File

@ -670,16 +670,16 @@ pub fn finishLoading() void {
} }
var subBiomeIterator = unfinishedSubBiomes.iterator(); var subBiomeIterator = unfinishedSubBiomes.iterator();
while(subBiomeIterator.next()) |subBiomeData| { while(subBiomeIterator.next()) |subBiomeData| {
const subBiomeDataList = subBiomeData.value_ptr;
defer subBiomeDataList.deinit(main.globalAllocator);
const parentBiome = biomesById.get(subBiomeData.key_ptr.*) orelse { const parentBiome = biomesById.get(subBiomeData.key_ptr.*) orelse {
std.log.warn("Couldn't find biome with id {s}. Cannot add sub-biomes.", .{subBiomeData.key_ptr.*}); std.log.warn("Couldn't find biome with id {s}. Cannot add sub-biomes.", .{subBiomeData.key_ptr.*});
continue; continue;
}; };
const subBiomeDataList = subBiomeData.value_ptr;
for(subBiomeDataList.items) |item| { for(subBiomeDataList.items) |item| {
parentBiome.subBiomeTotalChance += item.chance; parentBiome.subBiomeTotalChance += item.chance;
} }
parentBiome.subBiomes = .initFromContext(main.globalAllocator, subBiomeDataList.items); parentBiome.subBiomes = .initFromContext(main.globalAllocator, subBiomeDataList.items);
subBiomeDataList.deinit(main.globalAllocator);
} }
unfinishedSubBiomes.clearAndFree(main.globalAllocator.allocator); unfinishedSubBiomes.clearAndFree(main.globalAllocator.allocator);