AstralTransRocketries/HMCL
1
0
Fork 0
mirror of https://github.com/HMCL-dev/HMCL.git synced 2025-09-09 11:55:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: ConcurrentModificationException

Browse Source
This commit is contained in:
huanghongxun 2020-04-23 08:02:55 +08:00
parent 02cb2a3fb1
commit 43de254a98
2 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
HMCLCore/src/main/java/org/jackhuang/hmcl/download/VersionList.java
View File

@ -100,12 +100,7 @@ public abstract class VersionList<T extends RemoteVersion> {
} }
protected Collection<T> getVersionsImpl(String gameVersion) { protected Collection<T> getVersionsImpl(String gameVersion) {
lock.readLock().lock(); return versions.get(gameVersion);
try {
return versions.get(gameVersion);
} finally {
lock.readLock().unlock();
}
} }
/** /**
@ -115,7 +110,12 @@ public abstract class VersionList<T extends RemoteVersion> {
* @return the collection of specific remote versions * @return the collection of specific remote versions
*/ */
public final Collection<T> getVersions(String gameVersion) { public final Collection<T> getVersions(String gameVersion) {
return Collections.unmodifiableCollection(getVersionsImpl(gameVersion)); lock.readLock().lock();
try {
return Collections.unmodifiableCollection(new ArrayList<>(getVersionsImpl(gameVersion)));
} finally {
lock.readLock().unlock();
}
} }
/** /**

7
HMCLCore/src/main/java/org/jackhuang/hmcl/download/game/GameVersionList.java
View File

@ -45,12 +45,7 @@ public final class GameVersionList extends VersionList<GameRemoteVersion> {
@Override @Override
protected Collection<GameRemoteVersion> getVersionsImpl(String gameVersion) { protected Collection<GameRemoteVersion> getVersionsImpl(String gameVersion) {
lock.readLock().lock(); return versions.values();
try {
return versions.values();
} finally {
lock.readLock().unlock();
}
} }
@Override @Override