From b5c92c1564e76660ec7f126cdfa4421f33641ecd Mon Sep 17 00:00:00 2001 From: Glavo Date: Mon, 29 Aug 2022 19:27:51 +0800 Subject: [PATCH] Fix stuck on startup when no suitable Java is found (#1671) --- .../main/java/org/jackhuang/hmcl/game/LauncherHelper.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java b/HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java index 1ca3ebaca..97653df58 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/game/LauncherHelper.java @@ -369,7 +369,11 @@ public final class LauncherHelper { } } - if (targetJavaVersion != null) { + if (targetJavaVersion == null) { + Controllers.confirm(i18n("launch.failed.no_accepted_java"), i18n("message.warning"), MessageType.WARNING, continueAction, () -> { + future.completeExceptionally(new CancellationException("No accepted java")); + }); + } else { downloadJava(gameVersion.toString(), targetJavaVersion, profile) .thenAcceptAsync(downloadedJavaVersion -> { future.complete(downloadedJavaVersion);