From e01096bff08b6cf5a000116efca9718ac53f4d8b Mon Sep 17 00:00:00 2001 From: huanghongxun Date: Sat, 29 May 2021 15:15:40 +0800 Subject: [PATCH] fix: lint --- .../org/jackhuang/hmcl/setting/VersionSetting.java | 14 +++++++------- .../org/jackhuang/hmcl/game/LaunchOptions.java | 14 +++++++------- .../org/jackhuang/hmcl/launch/DefaultLauncher.java | 14 ++++++-------- 3 files changed, 20 insertions(+), 22 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java b/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java index 4cdd9b600..7de512572 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java @@ -67,7 +67,7 @@ public final class VersionSetting implements Cloneable { * 1. Global settings. * 2. Version settings. * If a version claims that it uses global settings, its version setting will be disabled. - * + *

* Defaults false because if one version uses global first, custom version file will not be generated. */ public boolean isUsesGlobal() { @@ -141,15 +141,15 @@ public final class VersionSetting implements Cloneable { private final StringProperty nativesDirProperty = new SimpleStringProperty(this, "nativesDirProperty", ""); - public StringProperty nativesDirProperty(){ + public StringProperty nativesDirProperty() { return nativesDirProperty; } - public String getNativesDir(){ + public String getNativesDir() { return nativesDirProperty.get(); } - public void setNativesDir(String nativesDir){ + public void setNativesDir(String nativesDir) { nativesDirProperty.set(nativesDir); } @@ -370,7 +370,7 @@ public final class VersionSetting implements Cloneable { /** * The server ip that will be entered after Minecraft successfully loaded ly. - * + *

* Format: ip:port or without port. */ public String getServerIp() { @@ -407,7 +407,7 @@ public final class VersionSetting implements Cloneable { /** * The width of Minecraft window, defaults 800. - * + *

* The field saves int value. * String type prevents unexpected value from JsonParseException. * We can only reset this field instead of recreating the whole setting file. @@ -429,7 +429,7 @@ public final class VersionSetting implements Cloneable { /** * The height of Minecraft window, defaults 480. - * + *

* The field saves int value. * String type prevents unexpected value from JsonParseException. * We can only reset this field instead of recreating the whole setting file. diff --git a/HMCLCore/src/main/java/org/jackhuang/hmcl/game/LaunchOptions.java b/HMCLCore/src/main/java/org/jackhuang/hmcl/game/LaunchOptions.java index de31799f4..39d261e6c 100644 --- a/HMCLCore/src/main/java/org/jackhuang/hmcl/game/LaunchOptions.java +++ b/HMCLCore/src/main/java/org/jackhuang/hmcl/game/LaunchOptions.java @@ -206,17 +206,17 @@ public class LaunchOptions implements Serializable { * 0 - ./minecraft/versions/<version>/natives * 1 - custom natives directory */ - public NativesDirectoryType getNativesDirType(){ + public NativesDirectoryType getNativesDirType() { return nativesDirType; } /** * Path to the natives directory, optional */ - public String getNativesDir(){ + public String getNativesDir() { return nativesDir; } - + public static class Builder { private final LaunchOptions options = new LaunchOptions(); @@ -369,11 +369,11 @@ public class LaunchOptions implements Serializable { return options.preLaunchCommand; } - public NativesDirectoryType getNativesDirType(){ + public NativesDirectoryType getNativesDirType() { return options.nativesDirType; } - public String getNativesDir(){ + public String getNativesDir() { return options.nativesDir; } @@ -479,12 +479,12 @@ public class LaunchOptions implements Serializable { return this; } - public Builder setNativesDirType(NativesDirectoryType nativesDirType){ + public Builder setNativesDirType(NativesDirectoryType nativesDirType) { options.nativesDirType = nativesDirType; return this; } - public Builder setNativesDir(String nativesDir){ + public Builder setNativesDir(String nativesDir) { options.nativesDir = nativesDir; return this; } diff --git a/HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java b/HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java index 405aed6ef..bef11c9e8 100644 --- a/HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java +++ b/HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java @@ -303,11 +303,10 @@ public class DefaultLauncher extends Launcher { File nativeFolder = null; if (options.getNativesDirType() == NativesDirectoryType.VERSION_FOLDER) { nativeFolder = repository.getNativeDirectory(version.getId()); - } - else { + } else { nativeFolder = new File(options.getNativesDir()); } - + // To guarantee that when failed to generate launch command line, we will not call pre-launch command List rawCommandLine = generateCommandLine(nativeFolder).asList(); @@ -317,7 +316,7 @@ public class DefaultLauncher extends Launcher { if (options.getNativesDirType() == NativesDirectoryType.VERSION_FOLDER) { decompressNatives(nativeFolder); - } + } File runDirectory = repository.getRunDirectory(version.getId()); @@ -360,14 +359,13 @@ public class DefaultLauncher extends Launcher { File nativeFolder = null; if (options.getNativesDirType() == NativesDirectoryType.VERSION_FOLDER) { nativeFolder = repository.getNativeDirectory(version.getId()); - } - else { + } else { nativeFolder = new File(options.getNativesDir()); } - + if (options.getNativesDirType() == NativesDirectoryType.VERSION_FOLDER) { decompressNatives(nativeFolder); - } + } if (isWindows && !FileUtils.getExtension(scriptFile).equals("bat")) throw new IllegalArgumentException("The extension of " + scriptFile + " is not 'bat' in Windows");