From e63ee49eaaafc8eac6dea3cc65b3abdc4fe57ada Mon Sep 17 00:00:00 2001 From: Haowei Wen Date: Sun, 29 Dec 2024 20:59:47 +0800 Subject: [PATCH] Remove VersionSetting.global property as it's unused --- .../org/jackhuang/hmcl/game/HMCLGameRepository.java | 1 - .../org/jackhuang/hmcl/setting/VersionSetting.java | 10 ---------- 2 files changed, 11 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java b/HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java index f02e5f393..26a148835 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java @@ -251,7 +251,6 @@ public class HMCLGameRepository extends DefaultGameRepository { public VersionSetting getVersionSetting(String id) { VersionSetting vs = getLocalVersionSetting(id); if (vs == null || vs.isUsesGlobal()) { - profile.getGlobal().setGlobal(true); // always keep global.isGlobal = true profile.getGlobal().setUsesGlobal(true); return profile.getGlobal(); } else diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java b/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java index aa084d119..cf337e3dd 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionSetting.java @@ -44,16 +44,6 @@ import static org.jackhuang.hmcl.util.logging.Logger.LOG; @JsonAdapter(VersionSetting.Serializer.class) public final class VersionSetting implements Cloneable { - private boolean global = false; - - public boolean isGlobal() { - return global; - } - - public void setGlobal(boolean global) { - this.global = global; - } - private final BooleanProperty usesGlobalProperty = new SimpleBooleanProperty(this, "usesGlobal", true); public BooleanProperty usesGlobalProperty() {