AstralTransRocketries/LucidCube
1
0
Fork 0
Code Issues Pull Requests Packages Projects 1 Releases Wiki Activity

Remove simple template-id from constructors for Vector3 template. (#5586)

Browse Source 
This was removed from the C++ standard in C++20; annoying warnings are produced by modern C++ compilers.

https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2237
This commit is contained in:
Alexander Harkness 2024-11-07 20:10:44 +00:00 committed by GitHub
parent ab62fc3988
commit 8ca73f1929
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Vector3.h
View File

@ -31,14 +31,14 @@ public:
// tolua_end // tolua_end
// Conversion constructors where U is not the same as T leaving the copy-constructor implicitly generated // Conversion constructors where U is not the same as T leaving the copy-constructor implicitly generated
template <typename U, std::enable_if_t<(!std::is_same<U, T>::value) && ((!std::is_integral<T>::value) || (std::is_integral<U>::value)), bool> = true> template <typename U, std::enable_if_t<(!std::is_same<U, T>::value) && ((!std::is_integral<T>::value) || (std::is_integral<U>::value)), bool> = true>
constexpr Vector3<T>(const Vector3<U> & a_Rhs): constexpr Vector3(const Vector3<U> & a_Rhs):
x(static_cast<T>(a_Rhs.x)), x(static_cast<T>(a_Rhs.x)),
y(static_cast<T>(a_Rhs.y)), y(static_cast<T>(a_Rhs.y)),
z(static_cast<T>(a_Rhs.z)) z(static_cast<T>(a_Rhs.z))
{ {
} }
template <typename U, std::enable_if_t<(!std::is_same<U, T>::value) && ((std::is_integral<T>::value) && (!std::is_integral<U>::value)), bool> = true> template <typename U, std::enable_if_t<(!std::is_same<U, T>::value) && ((std::is_integral<T>::value) && (!std::is_integral<U>::value)), bool> = true>
constexpr Vector3<T>(const Vector3<U> & a_Rhs): constexpr Vector3(const Vector3<U> & a_Rhs):
x(static_cast<T>(std::floor(a_Rhs.x))), x(static_cast<T>(std::floor(a_Rhs.x))),
y(static_cast<T>(std::floor(a_Rhs.y))), y(static_cast<T>(std::floor(a_Rhs.y))),
z(static_cast<T>(std::floor(a_Rhs.z))) z(static_cast<T>(std::floor(a_Rhs.z)))