Merge pull request #307 from mc-server/MobImprovements

Mob projectiles

MCServer/monsters.ini

@@ -69,10 +69,10 @@ SightDistance=25.0
 MaxHealth=20
 
 [Ghast]
-AttackRange=5.0
+AttackRange=50.0
 AttackRate=1
 AttackDamage=0.0
-SightDistance=25.0
+SightDistance=50.0
 MaxHealth=10
 
 [Silverfish]
@@ -83,10 +83,9 @@ SightDistance=25.0
 MaxHealth=8
 
 [Skeleton]
-AttackRange=5.0
+AttackRange=15.0
 AttackRate=1  
-AttackDamage=3.0
+SightDistance=40.0
-SightDistance=25.0
 MaxHealth=20
 
 [Slime]
@@ -111,7 +110,7 @@ SightDistance=25.0
 MaxHealth=20
 
 [Blaze]
-AttackRange=5.0
+AttackRange=15.0
 AttackRate=1  
 AttackDamage=6.0
 SightDistance=25.0

source/Mobs/AggressiveMonster.cpp

@@ -44,7 +44,7 @@ void cAggressiveMonster::InStateChasing(float a_Dt)
 		Vector3f Their = Vector3f( m_Target->GetPosition() );
 		if ((Their - Pos).Length() <= m_AttackRange)
 		{
-			cMonster::Attack(a_Dt);
+			Attack(a_Dt);
 		}
 		MoveToPosition(Their + Vector3f(0, 0.65f, 0));
 	}

source/Mobs/Blaze.cpp

@@ -2,7 +2,7 @@
 #include "Globals.h"  // NOTE: MSVC stupidness requires this to be the same across all modules
 
 #include "Blaze.h"
-
+#include "../World.h"
 
 
 
@@ -25,3 +25,28 @@ void cBlaze::GetDrops(cItems & a_Drops, cEntity * a_Killer)
 
 
 
+
+void cBlaze::Attack(float a_Dt)
+{
+	m_AttackInterval += a_Dt * m_AttackRate;
+
+	if (m_Target != NULL && m_AttackInterval > 3.0)
+	{
+		// Setting this higher gives us more wiggle room for attackrate
+		Vector3d Speed = GetLookVector() * 20;
+		Speed.y = Speed.y + 1;
+		cFireChargeEntity * FireCharge = new cFireChargeEntity(this, GetPosX(), GetPosY() + 1, GetPosZ(), Speed);
+		if (FireCharge == NULL)
+		{
+			return;
+		}
+		if (!FireCharge->Initialize(m_World))
+		{
+			delete FireCharge;
+			return;
+		}
+		m_World->BroadcastSpawnEntity(*FireCharge);
+		m_AttackInterval = 0.0;
+		// ToDo: Shoot 3 fireballs instead of 1.
+	}
+}

source/Mobs/Blaze.h

@@ -18,6 +18,7 @@ public:
 	CLASS_PROTODEF(cBlaze);
 	
 	virtual void GetDrops(cItems & a_Drops, cEntity * a_Killer = NULL) override;
+	virtual void Attack(float a_Dt) override;
 } ;
 
 

source/Mobs/Ghast.cpp

@@ -2,7 +2,7 @@
 #include "Globals.h"  // NOTE: MSVC stupidness requires this to be the same across all modules
 
 #include "Ghast.h"
-
+#include "../World.h"
 
 
 
@@ -25,3 +25,30 @@ void cGhast::GetDrops(cItems & a_Drops, cEntity * a_Killer)
 
 
 
+
+void cGhast::Attack(float a_Dt)
+{
+	m_AttackInterval += a_Dt * m_AttackRate;
+	
+	if (m_Target != NULL && m_AttackInterval > 3.0)
+	{
+		// Setting this higher gives us more wiggle room for attackrate
+		Vector3d Speed = GetLookVector() * 20;
+		Speed.y = Speed.y + 1;
+		cGhastFireballEntity * GhastBall = new cGhastFireballEntity(this, GetPosX(), GetPosY() + 1, GetPosZ(), Speed);
+		if (GhastBall == NULL)
+		{
+			return;
+		}
+		if (!GhastBall->Initialize(m_World))
+		{
+			delete GhastBall;
+			return;
+		}
+		m_World->BroadcastSpawnEntity(*GhastBall);
+		m_AttackInterval = 0.0;
+	}
+}
+
+
+

source/Mobs/Ghast.h

@@ -18,6 +18,7 @@ public:
 	CLASS_PROTODEF(cGhast);
 
 	virtual void GetDrops(cItems & a_Drops, cEntity * a_Killer = NULL) override;
+	virtual void Attack(float a_Dt) override;
 
 	bool IsCharging(void) const {return false; }
 } ;

source/Mobs/Monster.cpp

@@ -440,12 +440,12 @@ void cMonster::InStateEscaping(float a_Dt)
 void cMonster::Attack(float a_Dt)
 {
 	m_AttackInterval += a_Dt * m_AttackRate;
-	if ((m_Target != NULL) && (m_AttackInterval > 3.0))
+    if ((m_Target != NULL) && (m_AttackInterval > 3.0))
-	{
+    {
-		// Setting this higher gives us more wiggle room for attackrate
+        // Setting this higher gives us more wiggle room for attackrate
-		m_AttackInterval = 0.0;
+        m_AttackInterval = 0.0;
-		((cPawn *)m_Target)->TakeDamage(*this);
+        ((cPawn *)m_Target)->TakeDamage(*this);
-	}
+    }
 }
 
 

source/Mobs/Skeleton.cpp

@@ -7,7 +7,6 @@
 
 
 
-
 cSkeleton::cSkeleton(bool IsWither) :
 	super("Skeleton", mtSkeleton, "mob.skeleton.hurt", "mob.skeleton.death", 0.6, 1.8),
 	m_bIsWither(IsWither)
@@ -28,3 +27,44 @@ void cSkeleton::GetDrops(cItems & a_Drops, cEntity * a_Killer)
 
 
 
+
+void cSkeleton::MoveToPosition(const Vector3f & a_Position)
+{
+	m_Destination = a_Position;
+
+	// If the destination is in the sun and if it is not night AND the skeleton isn't on fire then block the movement.
+	if (!IsOnFire() && m_World->GetTimeOfDay() < 13187 && m_World->GetBlockSkyLight((int) a_Position.x, (int) a_Position.y, (int) a_Position.z) == 15)
+	{
+		m_bMovingToDestination = false;
+		return;
+	}
+	m_bMovingToDestination = true;
+}
+
+
+
+
+
+void cSkeleton::Attack(float a_Dt)
+{
+	m_AttackInterval += a_Dt * m_AttackRate;
+
+	if (m_Target != NULL && m_AttackInterval > 3.0)
+	{
+		// Setting this higher gives us more wiggle room for attackrate
+		Vector3d Speed = GetLookVector() * 20;
+		Speed.y = Speed.y + 1;
+		cArrowEntity * Arrow = new cArrowEntity(this, GetPosX(), GetPosY() + 1, GetPosZ(), Speed);
+		if (Arrow == NULL)
+		{
+			return;
+		}
+		if (!Arrow->Initialize(m_World))
+		{
+			delete Arrow;
+			return;
+		}
+		m_World->BroadcastSpawnEntity(*Arrow);
+		m_AttackInterval = 0.0;
+	}
+}

source/Mobs/Skeleton.h

@@ -18,6 +18,8 @@ public:
 	CLASS_PROTODEF(cSkeleton);
 
 	virtual void GetDrops(cItems & a_Drops, cEntity * a_Killer = NULL) override;
+	virtual void MoveToPosition(const Vector3f & a_Position) override;
+	virtual void Attack(float a_Dt) override;
 	bool IsWither(void) const { return m_bIsWither; };
 
 private:

source/Mobs/Zombie.cpp

@@ -30,3 +30,18 @@ void cZombie::GetDrops(cItems & a_Drops, cEntity * a_Killer)
 
 
 
+
+void cZombie::MoveToPosition(const Vector3f & a_Position)
+{
+	m_Destination = a_Position;
+
+	// If the destination is in the sun and if it is not night AND the skeleton isn't on fire then block the movement.
+	if ((m_World->GetBlockSkyLight((int) a_Position.x, (int) a_Position.y, (int) a_Position.z) == 15) && (m_World->GetTimeOfDay() < 13187) && !IsOnFire())
+	{
+		m_bMovingToDestination = false;
+		return;
+	}
+	m_bMovingToDestination = true;
+}
+
+

source/Mobs/Zombie.h

@@ -17,6 +17,7 @@ public:
 	CLASS_PROTODEF(cZombie);
 	
 	virtual void GetDrops(cItems & a_Drops, cEntity * a_Killer = NULL) override;
+	virtual void MoveToPosition(const Vector3f & a_Position) override;
 
 	bool IsVillagerZombie(void) const {return m_bIsVillagerZombie; }
 	bool IsConverting(void) const {return m_bIsConverting; }