AstralTransRocketries/MCGalaxy
1
0
Fork 0
mirror of https://github.com/ClassiCube/MCGalaxy.git synced 2025-08-03 19:36:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use custom StreamWriter to simplify process of more safely writing files to minimise risk of potential data loss

Browse Source
This commit is contained in:
UnknownShadow200 2025-03-07 21:34:47 +11:00
parent b6cc486990
commit 0adf900232
2 changed files with 30 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MCGalaxy/Bots/BotsFile.cs
View File

@ -87,11 +87,10 @@ namespace MCGalaxy.Bots {
props.Add(data);
}
string tmpPath = path + ".tmp";
try {
using (StreamWriter w = new StreamWriter(tmpPath)) { WriteAll(w, props); }
FileIO.Replace(tmpPath, path);
using (StreamWriter w = FileIO.CreateGuarded(path)) {
WriteAll(w, props);
}
} catch (Exception ex) {
Logger.LogError("Error saving bots to " + path, ex);
}

31
MCGalaxy/util/IO/FileIO.cs
View File

@ -57,11 +57,34 @@ namespace MCGalaxy
}
}
public static void Replace(string src, string dst) {
TryDelete(dst + ".old");
/// <summary> Returns a StreamWriter that writes data to a temp file path first,
/// and only overwrites the real file when .Dispose() is called </summary>
/// <remarks> Reduces the chance of data corruption in full disks </remarks>
public static StreamWriter CreateGuarded(string path) {
return new GuardedWriter(path);
}
class GuardedWriter : StreamWriter
{
readonly string realPath;
public GuardedWriter(string path) : base(path + ".tmp") {
realPath = path;
}
File.Move(dst, dst + ".old");
File.Move(src, dst);
protected override void Dispose(bool disposing) {
base.Dispose(disposing);
string src = realPath + ".tmp";
string dst = realPath;
string old = realPath + ".old";
FileIO.TryDelete(old);
bool didExist = FileIO.TryMove(dst, old);
File.Move(src, dst);
// Only delete old 'good' file if everything worked
if (didExist) FileIO.TryDelete(old);
}
}
}
}