From a1e2458327abb0c50134d42d82a53eda7f70e402 Mon Sep 17 00:00:00 2001 From: UnknownShadow200 Date: Wed, 17 Aug 2016 23:26:54 +1000 Subject: [PATCH] Minimise time pendingLock is locked for. --- Player/Player.Login.cs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Player/Player.Login.cs b/Player/Player.Login.cs index dae2e91f7..886df42ff 100644 --- a/Player/Player.Login.cs +++ b/Player/Player.Login.cs @@ -36,18 +36,17 @@ namespace MCGalaxy { truename = name; skinName = name; - lock (pendingLock) { - int altsCount = 0; + int altsCount = 0; + lock (pendingLock) { DateTime now = DateTime.UtcNow; foreach (PendingItem item in pendingNames) { if (item.Name == truename && (now - item.Connected).TotalSeconds <= 60) altsCount++; - } + } pendingNames.Add(new PendingItem(name)); - - if (altsCount > 0) { - Leave("Already logged in!", true); return; - } + } + if (altsCount > 0) { + Leave("Already logged in!", true); return; } string verify = enc.GetString(packet, 66, 32).Trim(); @@ -352,7 +351,7 @@ namespace MCGalaxy { string version = appName.Substring(spaceIndex, appName.Length - spaceIndex); Version ver; try { - ver = Version.Parse(version); + ver = new Version(version); } catch { return; }