AstralTransRocketries/MCGalaxy
1
0
Fork 0
mirror of https://github.com/ClassiCube/MCGalaxy.git synced 2025-09-22 12:05:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Just use count(id) for /sinfo on both backend, closes #255

Browse Source 
In the test SQLite database with 800,000 players there was a 2-3 millisecond difference. So not worth it.
This commit is contained in:
UnknownShadow200 2017-09-21 18:15:51 +10:00
parent 79de17943c
commit 774040e9d7
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
MCGalaxy/Commands/Information/CmdServerInfo.cs
View File

@ -62,21 +62,9 @@ namespace MCGalaxy.Commands.Info {
} }
static int GetPlayerCount() { static int GetPlayerCount() {
// Use fast path if possible TODO: fast path for mysql using (DataTable table = Database.Backend.GetRows("Players", "COUNT(id)")) {
int count = 0; return int.Parse(table.Rows[0]["COUNT(id)"].ToString());
if (!ServerConfig.UseMySQL) {
DataTable maxTable = Database.Backend.GetRows("Players", "MAX(_ROWID_)", "LIMIT 1");
if (maxTable.Rows.Count > 0) {
string row = maxTable.Rows[0]["MAX(_ROWID_)"].ToString();
maxTable.Dispose();
if (int.TryParse(row, out count) && count > 0) return count;
}
} }
DataTable table = Database.Backend.GetRows("Players", "COUNT(id)");
count = int.Parse(table.Rows[0]["COUNT(id)"].ToString());
table.Dispose();
return count;
} }
void ShowServerStats(Player p) { void ShowServerStats(Player p) {