From 9099cd891c43ba12ee3e38b4c120b03472df1b3b Mon Sep 17 00:00:00 2001 From: koiNoCirculation Date: Tue, 17 Oct 2023 15:29:27 -0700 Subject: [PATCH] Fix an error happened when connecting two nodes within the same network that causes a stack overflow crash. --- src/main/scala/li/cil/oc/server/network/Network.scala | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/scala/li/cil/oc/server/network/Network.scala b/src/main/scala/li/cil/oc/server/network/Network.scala index b09b60f6c..5b1f2f056 100644 --- a/src/main/scala/li/cil/oc/server/network/Network.scala +++ b/src/main/scala/li/cil/oc/server/network/Network.scala @@ -260,6 +260,9 @@ private class Network private(private val data: mutable.Map[String, Network.Vert addedNode.onConnect(addedNode) val visibleNodes = nodes.filter(_.reachability == Visibility.Network) visibleNodes.foreach(node => connects += ((node, nodes))) + } else if(addedNode.network == oldNode.data.network) { + //well this causes stack overflow + false } else { val otherNetwork = addedNode.network.asInstanceOf[Network.Wrapper].network