AstralTransRocketries/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2025-09-19 08:59:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid const-cast in WorldList - subclass is unnecessary and result->formats() is correct

Browse Source 
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
This commit is contained in:
TheKodeToad 2025-09-17 10:50:54 +01:00
parent 5ef61aa445
commit 24726ea621
No known key found for this signature in database
GPG Key ID: 5E39D70B4C93C38E
1 changed files with 16 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
launcher/minecraft/WorldList.cpp
View File

@ -36,6 +36,7 @@
#include "WorldList.h"
#include <FileSystem.h>
#include <qmimedata.h>
#include <QDebug>
#include <QDirIterator>
#include <QFileSystemWatcher>
@ -301,50 +302,31 @@ QStringList WorldList::mimeTypes() const
return types;
}
class WorldMimeData : public QMimeData {
Q_OBJECT
public:
WorldMimeData(QList<World> worlds) { m_worlds = worlds; }
QStringList formats() const { return QMimeData::formats() << "text/uri-list"; }
protected:
QVariant retrieveData(const QString& mimetype, QMetaType type) const
{
QMimeData* WorldList::mimeData(const QModelIndexList& indexes) const
{
QList<QUrl> urls;
for (auto& world : m_worlds) {
for (auto idx : indexes) {
if (idx.column() != 0)
continue;
int row = idx.row();
if (row < 0 || row >= this->m_worlds.size())
continue;
const World& world = m_worlds[row];
if (!world.isValid() || !world.isOnFS())
continue;
QString worldPath = world.container().absoluteFilePath();
qDebug() << worldPath;
urls.append(QUrl::fromLocalFile(worldPath));
}
const_cast<WorldMimeData*>(this)->setUrls(urls);
return QMimeData::retrieveData(mimetype, type);
}
private:
QList<World> m_worlds;
};
QMimeData* WorldList::mimeData(const QModelIndexList& indexes) const
{
if (indexes.size() == 0)
return new QMimeData();
QList<World> worlds_;
for (auto idx : indexes) {
if (idx.column() != 0)
continue;
int row = idx.row();
if (row < 0 || row >= this->m_worlds.size())
continue;
worlds_.append(this->m_worlds[row]);
}
if (!worlds_.size()) {
return new QMimeData();
}
return new WorldMimeData(worlds_);
auto result = new QMimeData();
result->setUrls(urls);
return result;
}
Qt::ItemFlags WorldList::flags(const QModelIndex& index) const
@ -453,5 +435,3 @@ void WorldList::loadWorldsAsync()
});
}
}
#include "WorldList.moc"