AstralTransRocketries/TrueCraft
Archived
1
0
Fork 0
Code Issues 48 Pull Requests 1 Packages Projects Releases Wiki Activity

Fix edge case with leaves and shears

Browse Source
This commit is contained in:
Drew DeVault 2015-06-26 17:25:08 -06:00
parent 9d1f5377ef
commit fea89a9462
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
TrueCraft/Handlers/InteractionHandlers.cs
View File

@ -11,6 +11,7 @@ using TrueCraft.Core.Entities;
using fNbt; using fNbt;
using TrueCraft.Core.Logic.Blocks; using TrueCraft.Core.Logic.Blocks;
using System.Linq; using System.Linq;
using TrueCraft.Core.Logic.Items;
namespace TrueCraft.Handlers namespace TrueCraft.Handlers
{ {
@ -50,7 +51,21 @@ namespace TrueCraft.Handlers
server.SendMessage(ChatColor.Red + "WARNING: block provider for ID {0} is null (player digging)", descriptor.ID); server.SendMessage(ChatColor.Red + "WARNING: block provider for ID {0} is null (player digging)", descriptor.ID);
else else
provider.BlockLeftClicked(descriptor, packet.Face, world, client); provider.BlockLeftClicked(descriptor, packet.Face, world, client);
if (provider != null && provider.Hardness == 0)
// "But why on Earth does this behavior change if you use shears on leaves?"
// "This is poor seperation of concerns"
// "Let me do a git blame and flame whoever wrote the next line"
// To answer all of those questions, here:
// Minecraft sends a player digging packet when the player starts and stops digging a block (two packets)
// However, it only sends ONE packet if the block would be mined immediately - which usually is only the case
// for blocks that have a hardness equal to zero.
// The exception to this rule is shears on leaves. Leaves normally have a hardness of 0.2, but when you mine them
// using shears the client only sends the start digging packet and expects them to be mined immediately.
// So if you want to blame anyone, send flames to Notch for the stupid idea of not sending "stop digging" packets
// for hardness == 0 blocks.
if (provider != null && provider.Hardness == 0
|| (client.SelectedItem.ID == ShearsItem.ItemID || provider is LeavesBlock))
provider.BlockMined(descriptor, packet.Face, world, client); provider.BlockMined(descriptor, packet.Face, world, client);
break; break;
case PlayerDiggingPacket.Action.StopDigging: case PlayerDiggingPacket.Action.StopDigging: