AstralTransRocketries/TrueCraft
Archived
1
0
Fork 0
Code Issues 48 Pull Requests 1 Packages Projects Releases Wiki Activity

Fixed multiple issues with lighting #224

Merged
moorehousew merged 1 commits from master into master 2015-11-24 12:56:42 -05:00
Conversation 6 Commits 1 Files Changed 8 +150 -19
moorehousew commented 2015-11-24 12:55:01 -05:00 (Migrated from github.com)
Copy Link

Chunk boundaries and special blocks are still lit incorrectly, but regular blocks work fine now.

Chunk boundaries and special blocks are still lit incorrectly, but regular blocks work fine now.
ddevault commented 2015-11-24 12:57:20 -05:00 (Migrated from github.com)
Copy Link

Woot!

Woot!
ddevault commented 2015-11-24 13:02:26 -05:00 (Migrated from github.com)
Copy Link

This is cool as shit, nice work!

This is cool as shit, nice work!
moorehousew commented 2015-11-24 13:07:10 -05:00 (Migrated from github.com)
Copy Link

Thanks. On another note, I've added a WorldLighting instance to ReadOnlyWorld, it calls the same lighting code the server does during various world-related events (chunk load, block change, etc.), yet the light level doesn't seem to change anywhere. Thoughts?

Thanks. On another note, I've added a `WorldLighting` instance to `ReadOnlyWorld`, it calls the same lighting code the server does during various world-related events (chunk load, block change, etc.), yet the light level doesn't seem to change anywhere. Thoughts?
ddevault commented 2015-11-24 13:07:49 -05:00 (Migrated from github.com)
Copy Link

I can't look into it too much while I'm at work, but I'll take a look later today and see what I can find out.

I can't look into it too much while I'm at work, but I'll take a look later today and see what I can find out.
moorehousew commented 2015-11-24 13:09:22 -05:00 (Migrated from github.com)
Copy Link

Okay, here's the commit for when you're free: bd51718743

Okay, here's the commit for when you're free: https://github.com/mrpimpunicorn/TrueCraft/commit/bd51718743b4d163b4957a7a74d1c8d9ee316b69
ddevault commented 2015-11-24 18:06:44 -05:00 (Migrated from github.com)
Copy Link

Okay, the issue is that the chunks have TerrainPopulated = false, which causes lighting operations to have no effect. I implemented relighting myself - but it ends up in some sort of feedback loop that freezes the game by queueing lighting operations exponentially. My work is in the lighting-fixes branch, will take another look later.

Okay, the issue is that the chunks have TerrainPopulated = false, which causes lighting operations to have no effect. I implemented relighting myself - but it ends up in some sort of feedback loop that freezes the game by queueing lighting operations exponentially. My work is in the lighting-fixes branch, will take another look later.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
future
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
oneechanhax
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AstralTransRocketries/TrueCraft#224
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?