AstralTransRocketries/TrueCraft
Archived
1
0
Fork 0
Code Issues 48 Pull Requests 1 Packages Projects Releases Wiki Activity

Make RenderThreadState a class instead of a struct #88

Merged
Mitch528 merged 4 commits from master into master 2015-05-18 12:16:54 -04:00
Conversation 6 Commits 4 Files Changed 5 +31 -30
Mitch528 commented 2015-05-18 01:11:14 -04:00 (Migrated from github.com)
Copy Link

Structs can't have parameterless constructors

Structs can't have parameterless constructors
ddevault commented 2015-05-18 01:11:44 -04:00 (Migrated from github.com)
Copy Link

Structs can't have parameterless constructors

...yes they can

> Structs can't have parameterless constructors ...yes they can
ddevault commented 2015-05-18 01:12:21 -04:00 (Migrated from github.com)
Copy Link

This also includes a bunch of unrelated changes.

This also includes a bunch of unrelated changes.
ddevault commented 2015-05-18 01:21:51 -04:00 (Migrated from github.com)
Copy Link

From IRC:

  • I'm unwittingly using a C# 6 feature here
  • The unrelated changes are necessary to make the build work on Windows

Next steps:

  • C# 6 is too young to expect everyone to have access to, so I'll merge this when:
  • The Windows build changes are put into their own commit
From IRC: - I'm unwittingly using a C# 6 feature here - The unrelated changes are necessary to make the build work on Windows Next steps: - C# 6 is too young to expect everyone to have access to, so I'll merge this when: - The Windows build changes are put into their own commit
ddevault commented 2015-05-18 12:15:24 -04:00 (Migrated from github.com)
Copy Link

Thanks, @Mitch528. Just to be sure - have you ever read the decompiled Minecraft source code?

Thanks, @Mitch528. Just to be sure - have you ever read the decompiled Minecraft source code?
Mitch528 commented 2015-05-18 12:16:32 -04:00 (Migrated from github.com)
Copy Link

No, I haven't.

No, I haven't.
ddevault commented 2015-05-18 12:16:51 -04:00 (Migrated from github.com)
Copy Link

Awesome, thanks!

Awesome, thanks!
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
future
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
oneechanhax
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AstralTransRocketries/TrueCraft#88
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?