From c297c4debc650f95973e819d8718a7ee777a63d3 Mon Sep 17 00:00:00 2001 From: yushijinhun Date: Mon, 31 Dec 2018 12:42:57 +0800 Subject: [PATCH] Remove unnecessary connection.connect()/disconnect() --- .../yushi/authlibinjector/httpd/URLProcessor.java | 1 - .../moe/yushi/authlibinjector/util/IOUtils.java | 15 +++++---------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/main/java/moe/yushi/authlibinjector/httpd/URLProcessor.java b/src/main/java/moe/yushi/authlibinjector/httpd/URLProcessor.java index 4f2d390..d9e7ed6 100644 --- a/src/main/java/moe/yushi/authlibinjector/httpd/URLProcessor.java +++ b/src/main/java/moe/yushi/authlibinjector/httpd/URLProcessor.java @@ -160,7 +160,6 @@ public class URLProcessor { conn.setRequestMethod(method); conn.setDoOutput(clientIn != null); requestHeaders.forEach(conn::setRequestProperty); - conn.connect(); if (clientIn != null) { try (OutputStream upstreamOut = conn.getOutputStream()) { diff --git a/src/main/java/moe/yushi/authlibinjector/util/IOUtils.java b/src/main/java/moe/yushi/authlibinjector/util/IOUtils.java index 9f4fc6c..c2c482e 100644 --- a/src/main/java/moe/yushi/authlibinjector/util/IOUtils.java +++ b/src/main/java/moe/yushi/authlibinjector/util/IOUtils.java @@ -25,16 +25,11 @@ public final class IOUtils { conn.setRequestProperty("Content-Type", contentType); conn.setRequestProperty("Content-Length", String.valueOf(payload.length)); conn.setDoOutput(true); - try { - conn.connect(); - try (OutputStream out = conn.getOutputStream()) { - out.write(payload); - } - try (InputStream in = conn.getInputStream()) { - return asBytes(in); - } - } finally { - conn.disconnect(); + try (OutputStream out = conn.getOutputStream()) { + out.write(payload); + } + try (InputStream in = conn.getInputStream()) { + return asBytes(in); } }