AstralTransRocketries/mcedit2
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DON'T EVER capture self in a closure like this!

Browse Source 
When a Qt signal is connected to a function that closes over any references, the GC can't ever detect this cycle: self -> some QObject -> Signal handler wrapper -> function with closure -> self.

ALWAYS use QSignalMapper instead of doing this crap!
This commit is contained in:
David Vierra 2015-09-15 01:12:22 -10:00
parent 8f481911c0
commit 047978ea52
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/mcedit2/editorsession.py
View File

@ -347,23 +347,20 @@ class EditorSession(QtCore.QObject):
# --- Dimensions ---
def _dimChanged(f):
def _changed():
self.gotoDimension(f)
return _changed
dimButton = self.changeDimensionButton = QtGui.QToolButton()
dimButton.setText(self.dimensionMenuLabel(""))
dimAction = self.changeDimensionAction = QtGui.QWidgetAction(self)
dimAction.setDefaultWidget(dimButton)
dimMenu = self.dimensionsMenu = QtGui.QMenu()
self.dimMapper = QtCore.QSignalMapper()
self.dimMapper.mapped[str].connect(self.gotoDimension)
for dimName in self.worldEditor.listDimensions():
displayName = self.dimensionDisplayName(dimName)
action = dimMenu.addAction(displayName)
action._changed = _dimChanged(dimName)
action.triggered.connect(action._changed)
self.dimMapper.setMapping(action, dimName)
action.triggered.connect(self.dimMapper.map)
dimButton.setMenu(dimMenu)
dimButton.setPopupMode(QtGui.QToolButton.InstantPopup)