From 544214ecea9647b16cb56bcaff9d416f6c1f271c Mon Sep 17 00:00:00 2001 From: David Vierra Date: Sun, 19 Jul 2015 02:10:00 -1000 Subject: [PATCH] Skip blank itemframes. This may be done improperly. Accessing ref.Item may create an empty compound, and I haven't checked if blank frames have an empty compound for Item or not. --- src/mcedit2/rendering/chunkmeshes/entitymesh.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mcedit2/rendering/chunkmeshes/entitymesh.py b/src/mcedit2/rendering/chunkmeshes/entitymesh.py index cc32bad..77728eb 100644 --- a/src/mcedit2/rendering/chunkmeshes/entitymesh.py +++ b/src/mcedit2/rendering/chunkmeshes/entitymesh.py @@ -339,8 +339,12 @@ class ItemFrameMesh(EntityMeshBase): if limitBox and ref.Position not in limitBox: continue - item = ref.Item - if item.itemType.internalName != "minecraft:filled_map": + try: + item = ref.Item + if item.itemType.internalName != "minecraft:filled_map": + continue + except KeyError: + log.exception("Error while getting ItemFrame item ID in frame at %s", ref.TilePos) continue mapID = item.Damage