AstralTransRocketries/minosoft
1
0
Fork 0
mirror of https://gitlab.bixilon.de/bixilon/minosoft.git synced 2025-09-09 23:42:35 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix fluid renderer top face invalidly culled

Browse Source
This commit is contained in:
Moritz Zwerger 2023-12-23 00:47:18 +01:00
parent 99096636a8
commit 65f88a90a2
No known key found for this signature in database
GPG Key ID: 5CAD791931B09AC4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/de/bixilon/minosoft/gui/rendering/chunk/mesher/FluidSectionMesher.kt
View File

@ -84,12 +84,15 @@ class FluidSectionMesher(
val model = fluid.model ?: continue val model = fluid.model ?: continue
val height = fluid.getHeight(state)
fun isSideCovered(direction: Directions): Boolean { fun isSideCovered(direction: Directions): Boolean {
val neighbour = direction.getBlock(x, y, z, section, neighbours) ?: return false val neighbour = direction.getBlock(x, y, z, section, neighbours) ?: return false
if (fluid.matches(neighbour)) { if (fluid.matches(neighbour)) {
return true return true
} }
if (direction == Directions.UP && height < 0.99f) return false
return FaceCulling.canCull(state, model.properties, direction, neighbour) return FaceCulling.canCull(state, model.properties, direction, neighbour)
} }
@ -106,7 +109,6 @@ class FluidSectionMesher(
if (skip.isTrue) continue if (skip.isTrue) continue
position = Vec3i(offsetX + x, offsetY + y, offsetZ + z) position = Vec3i(offsetX + x, offsetY + y, offsetZ + z)
val height = fluid.getHeight(state)
tint = tints.getFluidTint(chunk, fluid, height, position.x, position.y, position.z) ?: Colors.WHITE_RGB tint = tints.getFluidTint(chunk, fluid, height, position.x, position.y, position.z) ?: Colors.WHITE_RGB
val cornerHeights = floatArrayOf( val cornerHeights = floatArrayOf(
@ -118,7 +120,7 @@ class FluidSectionMesher(
val offsetPosition = Vec3(position - cameraOffset) val offsetPosition = Vec3(position - cameraOffset)
if (!skip[Directions.O_UP]) { if (cornerHeights[0] < 1.0f && !skip[Directions.O_UP]) {
val velocity = fluid.getVelocity(state, position, chunk) val velocity = fluid.getVelocity(state, position, chunk)
val still = velocity.x == 0.0 && velocity.z == 0.0 val still = velocity.x == 0.0 && velocity.z == 0.0
val texture: Texture val texture: Texture