From 870a691c7ed1ca1e403d09534089059ace057430 Mon Sep 17 00:00:00 2001
From: Bixilon <bixilon@bixilon.de>
Date: Fri, 18 Feb 2022 15:08:26 +0100
Subject: [PATCH] popper: calculate position properly

---
 .../gui/rendering/gui/popper/Popper.kt        | 35 +++++++++++++++++--
 .../rendering/gui/popper/text/TextPopper.kt   |  7 +++-
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/Popper.kt b/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/Popper.kt
index 1bb345995..d31abdf0d 100644
--- a/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/Popper.kt
+++ b/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/Popper.kt
@@ -21,6 +21,7 @@ import de.bixilon.minosoft.gui.rendering.gui.elements.primitive.ColorElement
 import de.bixilon.minosoft.gui.rendering.gui.mesh.GUIVertexConsumer
 import de.bixilon.minosoft.gui.rendering.gui.mesh.GUIVertexOptions
 import de.bixilon.minosoft.gui.rendering.util.vec.vec2.Vec2iUtil.EMPTY
+import de.bixilon.minosoft.gui.rendering.util.vec.vec2.Vec2iUtil.isSmaller
 import glm_.vec2.Vec2i
 
 abstract class Popper(
@@ -29,7 +30,7 @@ abstract class Popper(
 ) : Element(guiRenderer), LayoutedElement {
     private val background = ColorElement(guiRenderer, Vec2i.EMPTY, color = ChatColors.DARK_BLUE)
     open var dead = false
-    override var layoutOffset: Vec2i = position
+    override var layoutOffset: Vec2i = EMPTY
         protected set
     var position = position
         set(value) {
@@ -45,11 +46,36 @@ abstract class Popper(
     }
 
     override fun forceSilentApply() {
-        layoutOffset = position // ToDo
+        calculateLayoutOffset()
         background.size = size
         cacheUpToDate = false
     }
 
+
+    private fun calculateLayoutOffset() {
+        val windowSize = guiRenderer.scaledSize
+        val position = position
+        val size = size
+
+        // must not be at the position
+        // always try to make it on top of the position
+        // ToDo: if not possible, try: left -> right -> below
+        // if nothing is possible use (0|0)
+
+        val layoutOffset: Vec2i
+
+        // top
+        layoutOffset = position - Vec2i(0, size.y + POSITION_OFFSET)
+        if (!(layoutOffset isSmaller EMPTY)) {
+            layoutOffset.x = minOf(maxOf(layoutOffset.x - size.x / 2 - POSITION_OFFSET, 0), windowSize.x - size.x) // try to center element, but clamp on edges (try not to make the popper go out of the window)
+            this.layoutOffset = layoutOffset
+            return
+        }
+
+        // failover
+        this.layoutOffset = EMPTY
+    }
+
     fun show() {
         guiRenderer.popper += this
     }
@@ -57,4 +83,9 @@ abstract class Popper(
     fun hide() {
         dead = true
     }
+
+    companion object {
+        private val EMPTY = Vec2i.EMPTY
+        private const val POSITION_OFFSET = 5
+    }
 }
diff --git a/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/text/TextPopper.kt b/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/text/TextPopper.kt
index f1ec8f51d..f2f6a6d9e 100644
--- a/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/text/TextPopper.kt
+++ b/src/main/java/de/bixilon/minosoft/gui/rendering/gui/popper/text/TextPopper.kt
@@ -29,7 +29,7 @@ class TextPopper(
     private val textElement = TextElement(guiRenderer, text, background = false, parent = this)
 
     init {
-        recalculateSize()
+        forceSilentApply()
     }
 
     override fun forceRender(offset: Vec2i, consumer: GUIVertexConsumer, options: GUIVertexOptions?) {
@@ -38,6 +38,11 @@ class TextPopper(
         textElement.render(offset, consumer, options)
     }
 
+    override fun forceSilentApply() {
+        recalculateSize()
+        super.forceSilentApply()
+    }
+
     override fun onChildChange(child: Element) {
         recalculateSize()
     }