remove useless enum::getId to Enum::ordinal aliases

src/main/java/de/bixilon/minosoft/data/ChatTextPositions.java

@@ -21,8 +21,4 @@ public enum ChatTextPositions {
     public static ChatTextPositions byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }

src/main/java/de/bixilon/minosoft/data/Difficulties.java

@@ -22,8 +22,4 @@ public enum Difficulties {
     public static Difficulties byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }

src/main/java/de/bixilon/minosoft/data/Directions.java

@@ -24,8 +24,4 @@ public enum Directions {
     public static Directions byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }

src/main/java/de/bixilon/minosoft/data/SoundCategories.java

@@ -28,8 +28,4 @@ public enum SoundCategories {
     public static SoundCategories byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }

src/main/java/de/bixilon/minosoft/data/entities/Poses.java

@@ -25,8 +25,4 @@ public enum Poses {
     public static Poses byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }

src/main/java/de/bixilon/minosoft/protocol/packets/serverbound/handshaking/PacketHandshake.java

@@ -45,7 +45,7 @@ public class PacketHandshake implements ServerboundPacket {
         buffer.writeVarInt((nextState == ConnectionStates.STATUS ? -1 : connection.getVersion().getProtocolVersion())); // get best protocol version
         buffer.writeString(address.getHostname());
         buffer.writeShort((short) address.getPort());
-        buffer.writeVarInt(nextState.getId());
+        buffer.writeVarInt(nextState.ordinal());
         return buffer;
     }
 

src/main/java/de/bixilon/minosoft/protocol/packets/serverbound/play/PacketClientSettings.java

@@ -47,7 +47,7 @@ public class PacketClientSettings implements ServerboundPacket {
         buffer.writeByte((byte) 0x00); // chat settings (nobody uses them)
         buffer.writeBoolean(true); // chat colors
         if (buffer.getProtocolId() < 6) {
-            buffer.writeByte((byte) Difficulties.NORMAL.getId()); // difficulty
+            buffer.writeByte((byte) Difficulties.NORMAL.ordinal()); // difficulty
             buffer.writeBoolean(true); // cape
         } else {
             buffer.writeByte((byte) 0b01111111); // ToDo: skin parts

src/main/java/de/bixilon/minosoft/protocol/protocol/ConnectionStates.java

@@ -27,8 +27,4 @@ public enum ConnectionStates {
     public static ConnectionStates byId(int id) {
         return values()[id];
     }
-
-    public int getId() {
-        return ordinal();
-    }
 }