From f96047dbfe31a98ca4fdfa68f201492d7e1efeff Mon Sep 17 00:00:00 2001 From: Moritz Zwerger Date: Fri, 11 Apr 2025 14:10:14 +0200 Subject: [PATCH] world iterator: don't use abstract iterator Iterator allocates a boxed int (BlockPosition). This removes the whole benefit of the inlined datatype, allocates useless temporary memory and is potentially a lot slower. --- .../de/bixilon/minosoft/data/world/iterator/WorldIterator.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/bixilon/minosoft/data/world/iterator/WorldIterator.kt b/src/main/java/de/bixilon/minosoft/data/world/iterator/WorldIterator.kt index 4ce33f2a7..ef14f7bd6 100644 --- a/src/main/java/de/bixilon/minosoft/data/world/iterator/WorldIterator.kt +++ b/src/main/java/de/bixilon/minosoft/data/world/iterator/WorldIterator.kt @@ -22,12 +22,12 @@ import de.bixilon.minosoft.data.registries.blocks.shapes.collision.context.Entit import de.bixilon.minosoft.data.registries.blocks.types.fluid.FluidHolder import de.bixilon.minosoft.data.registries.blocks.types.properties.shape.collision.CollidableBlock import de.bixilon.minosoft.data.registries.shapes.aabb.AABB +import de.bixilon.minosoft.data.registries.shapes.aabb.AABBIterator import de.bixilon.minosoft.data.world.World import de.bixilon.minosoft.data.world.chunk.chunk.Chunk -import de.bixilon.minosoft.data.world.positions.BlockPosition class WorldIterator( - private val iterator: Iterator, + private val iterator: AABBIterator, private val world: World, private var chunk: Chunk? = null, ) : Iterator {