From b44e052f2840040798923cea794dc1c8da9b0dd6 Mon Sep 17 00:00:00 2001 From: allain Date: Sun, 27 Aug 2017 21:55:42 -0400 Subject: [PATCH 1/2] store minecraft jars in /tmp unless overriden by ENV variable --- test/clientTest.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/clientTest.js b/test/clientTest.js index 882febe..4aaedcc 100644 --- a/test/clientTest.js +++ b/test/clientTest.js @@ -19,7 +19,7 @@ mc.supportedVersions.forEach(function(supportedVersion,i) { const PORT=Math.round(30000+Math.random()*20000); const mcData = require("minecraft-data")(supportedVersion); const version = mcData.version; - const MC_SERVER_JAR_DIR = process.env.MC_SERVER_JAR_DIR; + const MC_SERVER_JAR_DIR = process.env.MC_SERVER_JAR_DIR || '/tmp'; const MC_SERVER_JAR = MC_SERVER_JAR_DIR + "/minecraft_server." + version.minecraftVersion + ".jar"; const wrap = new Wrap(MC_SERVER_JAR, MC_SERVER_PATH+"_"+supportedVersion); wrap.on('line', function(line) { From 137320489cc0f852c925d4bd3637e03cdf32c418 Mon Sep 17 00:00:00 2001 From: allain Date: Mon, 28 Aug 2017 10:13:59 -0400 Subject: [PATCH 2/2] using os.tmpdir() instead of '/tmp' since it's more portable --- test/clientTest.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/clientTest.js b/test/clientTest.js index 4aaedcc..f3d57a3 100644 --- a/test/clientTest.js +++ b/test/clientTest.js @@ -1,4 +1,5 @@ const mc = require('../'); +const os = require('os'); const Server = mc.Server; const path = require('path'); const assert = require('power-assert'); @@ -19,7 +20,7 @@ mc.supportedVersions.forEach(function(supportedVersion,i) { const PORT=Math.round(30000+Math.random()*20000); const mcData = require("minecraft-data")(supportedVersion); const version = mcData.version; - const MC_SERVER_JAR_DIR = process.env.MC_SERVER_JAR_DIR || '/tmp'; + const MC_SERVER_JAR_DIR = process.env.MC_SERVER_JAR_DIR || os.tmpdir(); const MC_SERVER_JAR = MC_SERVER_JAR_DIR + "/minecraft_server." + version.minecraftVersion + ".jar"; const wrap = new Wrap(MC_SERVER_JAR, MC_SERVER_PATH+"_"+supportedVersion); wrap.on('line', function(line) {