From 562c7ebec7f45039088bd465f4c7395c1570b734 Mon Sep 17 00:00:00 2001
From: Romain Beaumont <romain.rom1@gmail.com>
Date: Fri, 21 Jul 2017 22:15:50 +0200
Subject: [PATCH] dynamic autoversion server

---
 src/createServer.js     | 10 ++++++----
 src/server/handshake.js | 14 ++++++++++----
 src/server/login.js     |  2 +-
 3 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/createServer.js b/src/createServer.js
index 8aec9c8..38010ba 100644
--- a/src/createServer.js
+++ b/src/createServer.js
@@ -18,17 +18,19 @@ function createServer(options={}) {
     port = serverPort || 25565,
     motd = "A Minecraft server",
     'max-players' : maxPlayers = 20,
-    version : optVersion = require("./version").defaultVersion,
+    version,
     favicon,
     customPackets
   } = options;
 
+  const optVersion = version===undefined || version===false ? require("./version").defaultVersion : version;
+
   const mcData=require("minecraft-data")(optVersion);
-  const version = mcData.version;
+  const mcversion = mcData.version;
 
 
-  const server = new Server(version.minecraftVersion,customPackets);
-  server.mcversion=version;
+  const server = new Server(mcversion.minecraftVersion,customPackets);
+  server.mcversion=mcversion;
   server.motd = motd;
   server.maxPlayers = maxPlayers;
   server.playerCount = 0;
diff --git a/src/server/handshake.js b/src/server/handshake.js
index c7e5be2..ead053d 100644
--- a/src/server/handshake.js
+++ b/src/server/handshake.js
@@ -1,6 +1,6 @@
 const states = require("../states");
 
-module.exports=function(client,server) {
+module.exports=function(client,server,{version}) {
 
   client.once('set_protocol', onHandshake);
 
@@ -8,14 +8,20 @@ module.exports=function(client,server) {
     client.serverHost = packet.serverHost;
     client.serverPort = packet.serverPort;
     client.protocolVersion = packet.protocolVersion;
+
+
+    if(version === false || version === undefined) {
+      client.version=client.protocolVersion;
+    }
+    else if (client.protocolVersion !== server.mcversion.version) {
+      client.end("Wrong protocol version, expected: " + server.mcversion.version + " and you are using: " + client.protocolVersion);
+    }
+
     if (packet.nextState === 1) {
       client.state = states.STATUS;
     } else if (packet.nextState === 2) {
       client.state = states.LOGIN;
     }
-    if (client.protocolVersion !== server.mcversion.version) {
-      client.end("Wrong protocol version, expected: " + server.mcversion.version + " and you are using: " + client.protocolVersion);
-    }
   }
 
 };
diff --git a/src/server/login.js b/src/server/login.js
index df5dad7..6a15300 100644
--- a/src/server/login.js
+++ b/src/server/login.js
@@ -115,7 +115,7 @@ module.exports=function(client,server,options) {
     if(onlineMode === false || isException) {
       client.uuid = nameToMcOfflineUUID(client.username);
     }
-    if (server.mcversion.version >= 27) { // 14w28a (27) added whole-protocol compression (http://wiki.vg/Protocol_History#14w28a), earlier versions per-packet compressed TODO: refactor into minecraft-data
+    if (client.protocolVersion >= 27) { // 14w28a (27) added whole-protocol compression (http://wiki.vg/Protocol_History#14w28a), earlier versions per-packet compressed TODO: refactor into minecraft-data
       client.write('compress', { threshold: 256 }); // Default threshold is 256
       client.compressionThreshold = 256;
     }