AstralTransRocketries/node-minecraft-protocol
1
0
Fork 0
mirror of https://github.com/unmojang/node-minecraft-protocol.git synced 2025-09-29 06:03:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

more decompression more reliable : ignore packet that cannot be decompressed

Browse Source 
do print an error though, because servers should not send wrong packets

mitigate #462
This commit is contained in:
Romain Beaumont 2018-05-20 02:50:26 +02:00
parent 9778bb920b
commit 571d0e0c25
No known key found for this signature in database
GPG Key ID: DB60E388B3BCF286
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/transforms/compression.js
View File

@ -52,7 +52,17 @@ class Decompressor extends Transform {
return cb() return cb()
} else { } else {
zlib.inflate(chunk.slice(size), (err, newBuf) => { zlib.inflate(chunk.slice(size), (err, newBuf) => {
if (err) { return cb(err) } if (err) {
console.error('problem inflating chunk')
console.error('uncompressed length ' + value)
console.error('compressed length ' + chunk.length)
console.error('hex ' + chunk.toString('hex'))
console.log(err)
return cb()
}
if (newBuf.length !== value) {
console.error('uncompressed length should be ' + value + ' but is ' + newBuf.length)
}
this.push(newBuf) this.push(newBuf)
return cb() return cb()
}) })