AstralTransRocketries/node-minecraft-protocol
1
0
Fork 0
mirror of https://github.com/unmojang/node-minecraft-protocol.git synced 2025-09-28 13:45:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use new object for ping() to avoid potential cross-contamination

Browse Source
This commit is contained in:
deathcap 2016-01-31 12:26:03 -08:00
parent d0f64e9c65
commit f17de6410b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/client/autoVersion.js
View File

@ -24,11 +24,11 @@ function protocolVersion2MinecraftVersion(n) {
module.exports = function(client) { module.exports = function(client) {
var options = client.options; var options = client.options;
debug('creating client');
options.wait_connect = true; // don't let src/client/setProtocol proceed on socket 'connect' until 'connect_allowed' options.wait_connect = true; // don't let src/client/setProtocol proceed on socket 'connect' until 'connect_allowed'
debug('pinging',options.host); debug('pinging',options.host);
// TODO: detect ping timeout, https://github.com/PrismarineJS/node-minecraft-protocol/issues/329 var pingOptions = {host: options.host, port: options.port};
ping(options, function(err, response) { // TODO: use 0xfe ping instead for better compatibility/performance? https://github.com/deathcap/node-minecraft-ping
ping(pingOptions, function(err, response) {
if (err) throw err; // hmm if (err) throw err; // hmm
debug('ping response',response); debug('ping response',response);
// TODO: could also use ping pre-connect to save description, type, negotiate protocol etc. // TODO: could also use ping pre-connect to save description, type, negotiate protocol etc.