From 5af69bc8fbe0040cc7d12c5a6431417aaffb6eee Mon Sep 17 00:00:00 2001 From: artdeell Date: Sat, 26 Aug 2023 22:55:55 +0300 Subject: [PATCH] Chore[tools]: add comment explaining the reasoning for ASM version replacement --- app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java index c4ac07c29..e2f7d711b 100644 --- a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java +++ b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/Tools.java @@ -666,6 +666,9 @@ public final class Tools { libItem.downloads.artifact.sha1 = "9e98cf55be371cafdb9c70c35d04ec2a8c2b42ac"; libItem.downloads.artifact.url = "https://repo1.maven.org/maven2/com/github/oshi/oshi-core/6.3.0/oshi-core-6.3.0.jar"; } else if (libItem.name.startsWith("org.ow2.asm:asm-all:")) { + // Early versions of the ASM library get repalced with 5.0.4 because Pojav's LWJGL is compiled for + // Java 8, which is not supported by old ASM versions. Mod loaders like Forge, which depend on this + // library, often include lwjgl in their class transformations, which causes errors with old ASM versions. if(Integer.parseInt(version[0]) >= 5) continue; Log.d(APP_NAME, "Library " + libItem.name + " has been changed to version 5.0.4"); createLibraryInfo(libItem);