From df0b762cf38a73ae0ccf51a7e9783c428490e500 Mon Sep 17 00:00:00 2001 From: TarikBR <64391349+TarikBR@users.noreply.github.com> Date: Tue, 25 Jun 2024 14:33:38 -0300 Subject: [PATCH] fix(progresskeeper): dont remove task count listener until it reaches 0 (#5650) If waitUltilDone() is called when you have 2 or more other tasks, the first one that is changed will still have tasks to wait for, but when it finishes it won't run because it was removed early. (translated) --- .../java/net/kdt/pojavlaunch/progresskeeper/ProgressKeeper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/progresskeeper/ProgressKeeper.java b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/progresskeeper/ProgressKeeper.java index e5a3b31db..41a5b5293 100644 --- a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/progresskeeper/ProgressKeeper.java +++ b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/progresskeeper/ProgressKeeper.java @@ -90,8 +90,8 @@ public class ProgressKeeper { public void onUpdateTaskCount(int taskCount) { if(taskCount == 0) { runnable.run(); + removeTaskCountListener(this); } - removeTaskCountListener(this); } }; addTaskCountListener(listener);