From 82a7151d30985c97008fc8d4372370cbe2e1f7ad Mon Sep 17 00:00:00 2001
From: hneemann <helmut.neemann@arcor.de>
Date: Thu, 3 Jan 2019 18:04:33 +0100
Subject: [PATCH] fixed some findbugs issues

---
 pom.xml                                       | 29 ++++++++++---------
 .../digital/draw/graphics/Polygon.java        |  2 +-
 .../digital/draw/graphics/SVGTokenizer.java   |  2 +-
 3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/pom.xml b/pom.xml
index cfca4b62d..511c89c73 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,28 +27,26 @@
     <reporting>
         <plugins>
             <plugin>
-                <groupId>org.codehaus.mojo</groupId>
-                <artifactId>findbugs-maven-plugin</artifactId>
-                <version>3.0.1</version>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-project-info-reports-plugin</artifactId>
+                <version>3.0.0</version>
             </plugin>
             <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <version>3.0.5</version>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-pmd-plugin</artifactId>
-                <version>3.6</version>
+                <version>3.11.0</version>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>2.10.2</version>
+                <version>3.0.1</version>
                 <configuration>
                     <failOnError>false</failOnError>
-                    <doclet>org.umlgraph.doclet.UmlGraphDoc</doclet>
-                    <docletArtifact>
-                        <groupId>org.umlgraph</groupId>
-                        <artifactId>umlgraph</artifactId>
-                        <version>5.6</version>
-                    </docletArtifact>
-                    <additionalparam>-views -all</additionalparam>
-                    <useStandardDocletOptions>true</useStandardDocletOptions>
                 </configuration>
             </plugin>
         </plugins>
@@ -258,6 +256,11 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-site-plugin</artifactId>
+                <version>3.7.1</version>
+            </plugin>
         </plugins>
     </build>
 
diff --git a/src/main/java/de/neemann/digital/draw/graphics/Polygon.java b/src/main/java/de/neemann/digital/draw/graphics/Polygon.java
index 13150d53d..55fbc26f7 100644
--- a/src/main/java/de/neemann/digital/draw/graphics/Polygon.java
+++ b/src/main/java/de/neemann/digital/draw/graphics/Polygon.java
@@ -518,7 +518,7 @@ public class Polygon implements Iterable<Polygon.PathElement> {
         }
     }
 
-    private class ClosePath implements PathElement {
+    private static final class ClosePath implements PathElement {
         @Override
         public VectorInterface getPoint() {
             return null;
diff --git a/src/main/java/de/neemann/digital/draw/graphics/SVGTokenizer.java b/src/main/java/de/neemann/digital/draw/graphics/SVGTokenizer.java
index 85e07c1af..6ccf1b48a 100644
--- a/src/main/java/de/neemann/digital/draw/graphics/SVGTokenizer.java
+++ b/src/main/java/de/neemann/digital/draw/graphics/SVGTokenizer.java
@@ -242,7 +242,7 @@ public class SVGTokenizer {
     /**
      * Exception thrown by the tokenizer
      */
-    public final class TokenizerException extends Exception {
+    public static final class TokenizerException extends Exception {
         private TokenizerException(String message) {
             super(message);
         }