From 9f56f7b37a5b79e594524f1ad674e1166e90cc93 Mon Sep 17 00:00:00 2001 From: hneemann Date: Sun, 10 Apr 2016 10:21:10 +0200 Subject: [PATCH] fixed some findbugs issues --- src/main/java/de/neemann/digital/core/Model.java | 16 ++++++++++++++++ .../digital/draw/graphics/GraphicSVG.java | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/main/java/de/neemann/digital/core/Model.java b/src/main/java/de/neemann/digital/core/Model.java index 706157108..24c7004d9 100644 --- a/src/main/java/de/neemann/digital/core/Model.java +++ b/src/main/java/de/neemann/digital/core/Model.java @@ -430,6 +430,22 @@ public class Model { return name.compareTo(o.name); } + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + Signal signal = (Signal) o; + + return name.equals(signal.name); + + } + + @Override + public int hashCode() { + return name.hashCode(); + } + @Override public String toString() { return name; diff --git a/src/main/java/de/neemann/digital/draw/graphics/GraphicSVG.java b/src/main/java/de/neemann/digital/draw/graphics/GraphicSVG.java index 15360cab4..b61cb8076 100644 --- a/src/main/java/de/neemann/digital/draw/graphics/GraphicSVG.java +++ b/src/main/java/de/neemann/digital/draw/graphics/GraphicSVG.java @@ -93,7 +93,7 @@ public class GraphicSVG implements Graphic, Closeable { public void drawCircle(Vector p1, Vector p2, Style style) { try { Vector c = p1.add(p2).div(2); - double r = Math.abs(p2.sub(p1).x) / 2; + double r = Math.abs(p2.sub(p1).x) / 2.0; if (style.isFilled()) w.write("\n"); else {