TheCloud/Digital
1
0
Fork 0
mirror of https://github.com/hneemann/Digital.git synced 2025-09-28 23:45:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

fixed a bug witch result in values always zero if 64 bit values are used.

Browse Source
This commit is contained in:
hneemann 2017-03-04 17:29:12 +01:00
parent 4a6a8958fc
commit a3a609178c
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/de/neemann/digital/core/ObservableValue.java
View File

@ -39,7 +39,10 @@ public class ObservableValue extends Observable implements PinDescription {
super(); super();
this.bits = bits; this.bits = bits;
this.highZ = highZ; this.highZ = highZ;
mask = (1L << bits) - 1; if (bits > 63)
mask = -1;
else
mask = (1L << bits) - 1;
this.name = name; this.name = name;
supportsHighZ = highZ; supportsHighZ = highZ;
} }

28
src/test/java/de/neemann/digital/core/ObservableValueTest.java Normal file
View File

@ -0,0 +1,28 @@
package de.neemann.digital.core;
import junit.framework.TestCase;
/**
* Created by hneemann on 04.03.17.
*/
public class ObservableValueTest extends TestCase {
public void testSetValue1() throws Exception {
ObservableValue v = new ObservableValue("z", 64);
v.setValue(5);
assertEquals(5, v.getValue());
}
public void testSetValue2() throws Exception {
ObservableValue v = new ObservableValue("z", 63);
v.setValue(-1);
assertEquals((1l << 63) - 1, v.getValue());
}
public void testSetValue3() throws Exception {
ObservableValue v = new ObservableValue("z", 62);
v.setValue(-1);
assertEquals((1l << 62) - 1, v.getValue());
}
}