diff --git a/pom.xml b/pom.xml
index 9524c728c..fbd734902 100644
--- a/pom.xml
+++ b/pom.xml
@@ -36,21 +36,6 @@
findbugs-maven-plugin
3.0.1
-
- org.apache.maven.plugins
- maven-checkstyle-plugin
- 2.17
-
- sun_checks_neemann.xml
-
-
-
-
- checkstyle
-
-
-
-
maven-pmd-plugin
3.6
@@ -76,6 +61,22 @@
+
+
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ 2.17
+
+
+ com.puppycrawl.tools
+ checkstyle
+ 7.6
+
+
+
+
+
org.apache.maven.plugins
@@ -152,6 +153,27 @@
+
+ org.apache.maven.plugins
+ maven-checkstyle-plugin
+ 2.17
+
+
+ validate
+ validate
+
+ sun_checks_neemann.xml
+ UTF-8
+ true
+ true
+
+
+ check
+
+
+
+
+
org.apache.maven.plugins
maven-assembly-plugin
diff --git a/src/main/java/de/neemann/digital/core/Signal.java b/src/main/java/de/neemann/digital/core/Signal.java
index 5acbebf63..d81567318 100644
--- a/src/main/java/de/neemann/digital/core/Signal.java
+++ b/src/main/java/de/neemann/digital/core/Signal.java
@@ -17,7 +17,8 @@ public final class Signal implements Comparable {
* @param value the signals value
*/
public Signal(String name, ObservableValue value) {
- this.name = name.trim().replace(' ', '_');
+ if (name == null) this.name = null;
+ else this.name = name.trim().replace(' ', '_');
this.value = value;
}
diff --git a/src/main/java/de/neemann/digital/draw/elements/Wire.java b/src/main/java/de/neemann/digital/draw/elements/Wire.java
index ebfdff640..758d61e9b 100644
--- a/src/main/java/de/neemann/digital/draw/elements/Wire.java
+++ b/src/main/java/de/neemann/digital/draw/elements/Wire.java
@@ -15,6 +15,9 @@ import java.util.Collection;
*/
public class Wire implements Drawable, Moveable {
private static final int MIN_LABEL_LEN = 80;
+ //Every value of p1 or p2 is valid. There are no hidden state constrains or dependencies.
+ //So both fields are allowed to by public to allow more readable code.
+ //CHECKSTYLE.OFF: VisibilityModifier
/**
* The first endpoint of the line
*/
@@ -23,6 +26,7 @@ public class Wire implements Drawable, Moveable {
* The second endpoint of the line
*/
public Vector p2;
+ //CHECKSTYLE.ON: VisibilityModifier
private transient ObservableValue value;
private transient boolean p1Dot;
private transient boolean p2Dot;