From 374f8b8120b2d4fe0b4108d298dd8f1155349d8f Mon Sep 17 00:00:00 2001
From: Valentyne Stigloher <pixunil@posteo.eu>
Date: Thu, 2 Jan 2025 23:12:37 +0100
Subject: [PATCH] (ts) migrate remaining .js files in ~/src to typescript

---
 components/AdPlaceholder.vue                 |  4 +-
 components/CalendarExtra.vue                 |  2 +-
 components/Footer.vue                        |  2 +-
 components/Share.vue                         |  2 +-
 components/Socials.vue                       | 11 ++---
 components/Support.vue                       |  2 +-
 pages/admin/timesheets/index.vue             |  2 +-
 pages/admin/timesheets/overview.vue          |  2 +-
 pages/contact.vue                            | 12 +++---
 src/{adPlaceholders.js => adPlaceholders.ts} |  0
 src/{adsInternal.js => adsInternal.ts}       | 16 +++++--
 src/{contact.js => contact.ts}               | 44 +++++++++++---------
 src/{timesheets.js => timesheets.ts}         |  2 +-
 13 files changed, 56 insertions(+), 45 deletions(-)
 rename src/{adPlaceholders.js => adPlaceholders.ts} (100%)
 rename src/{adsInternal.js => adsInternal.ts} (89%)
 rename src/{contact.js => contact.ts} (84%)
 rename src/{timesheets.js => timesheets.ts} (99%)

diff --git a/components/AdPlaceholder.vue b/components/AdPlaceholder.vue
index 2235e373b..f7bc9a5f1 100644
--- a/components/AdPlaceholder.vue
+++ b/components/AdPlaceholder.vue
@@ -40,8 +40,8 @@
 import { mapState } from 'pinia';
 
 import useConfig from '../composables/useConfig.ts';
-import adPlaceholders from '../src/adPlaceholders.js';
-import getAdsInternal from '../src/adsInternal.js';
+import adPlaceholders from '../src/adPlaceholders.ts';
+import getAdsInternal from '../src/adsInternal.ts';
 import { randomItemWeighted } from '../src/helpers.ts';
 import { useMainStore } from '../store/index.ts';
 
diff --git a/components/CalendarExtra.vue b/components/CalendarExtra.vue
index 6fcf446e8..ff9b7af94 100644
--- a/components/CalendarExtra.vue
+++ b/components/CalendarExtra.vue
@@ -67,7 +67,7 @@
 
 <script>
 import useConfig from '../composables/useConfig.ts';
-import { socialLinks } from '../src/contact.js';
+import { socialLinks } from '../src/contact.ts';
 import { clearUrl } from '../src/helpers.ts';
 
 export default {
diff --git a/components/Footer.vue b/components/Footer.vue
index d61e90274..dbec6e0b5 100644
--- a/components/Footer.vue
+++ b/components/Footer.vue
@@ -194,7 +194,7 @@ import { useFetch } from 'nuxt/app';
 
 import useConfig from '../composables/useConfig.ts';
 import useDialogue from '../composables/useDialogue.ts';
-import { getContactLinks, getSocialLinks, getSupportLinks } from '../src/contact.js';
+import { getContactLinks, getSocialLinks, getSupportLinks } from '../src/contact.ts';
 import { sessionCookieSetting } from '../src/cookieSettings.ts';
 import { groupBy } from '../src/helpers.ts';
 import { useMainStore } from '../store/index.ts';
diff --git a/components/Share.vue b/components/Share.vue
index 6489a1e78..ed2df4a09 100644
--- a/components/Share.vue
+++ b/components/Share.vue
@@ -29,7 +29,7 @@
 <script>
 import ClipboardJS from 'clipboard';
 
-import { COLOURS } from '../src/contact.js';
+import { COLOURS } from '../src/contact.ts';
 
 // adapted from https://shareon.js.org (MIT)
 // can't use from yarn, because window.onload conflicts with SSR
diff --git a/components/Socials.vue b/components/Socials.vue
index 189b43ee1..bcc519bd7 100644
--- a/components/Socials.vue
+++ b/components/Socials.vue
@@ -21,18 +21,15 @@
 import { defineComponent } from 'vue';
 
 import useConfig from '../composables/useConfig.ts';
-import { getSocialLinks } from '../src/contact.js';
+import { getSocialLinks } from '../src/contact.ts';
 import { groupBy } from '../src/helpers.ts';
 
 export default defineComponent({
     setup() {
+        const config = useConfig();
         return {
-            config: useConfig(),
-        };
-    },
-    data() {
-        return {
-            socials: groupBy([...getSocialLinks(this.config)], (l) => l.group),
+            config,
+            socials: groupBy([...getSocialLinks(config)], (l) => l.group),
         };
     },
 });
diff --git a/components/Support.vue b/components/Support.vue
index ef3bd4e2b..ddada3486 100644
--- a/components/Support.vue
+++ b/components/Support.vue
@@ -29,7 +29,7 @@
 </template>
 
 <script>
-import { getSupportLinks } from '../src/contact.js';
+import { getSupportLinks } from '../src/contact.ts';
 
 export default {
     data() {
diff --git a/pages/admin/timesheets/index.vue b/pages/admin/timesheets/index.vue
index 775a308ef..d12fb3e62 100644
--- a/pages/admin/timesheets/index.vue
+++ b/pages/admin/timesheets/index.vue
@@ -151,7 +151,7 @@ import { useNuxtApp } from 'nuxt/app';
 
 import useDialogue from '~/composables/useDialogue.ts';
 import useSimpleHead from '~/composables/useSimpleHead.ts';
-import { min, max, closed, MONTHS, AREAS, TRANSFER_METHODS } from '~/src/timesheets.js';
+import { min, max, closed, MONTHS, AREAS, TRANSFER_METHODS } from '~/src/timesheets.ts';
 
 export default {
     async setup() {
diff --git a/pages/admin/timesheets/overview.vue b/pages/admin/timesheets/overview.vue
index fb9fb71d8..6fe807fb0 100644
--- a/pages/admin/timesheets/overview.vue
+++ b/pages/admin/timesheets/overview.vue
@@ -108,7 +108,7 @@ import { DateTime } from 'luxon';
 import { useNuxtApp } from 'nuxt/app';
 
 import useSimpleHead from '~/composables/useSimpleHead.ts';
-import { min, max, MONTHS, PERIODS } from '~/src/timesheets.js';
+import { min, max, MONTHS, PERIODS } from '~/src/timesheets.ts';
 
 function* range(start, end) {
     for (let i = start; i <= end; i++) {
diff --git a/pages/contact.vue b/pages/contact.vue
index 5425fa862..213452c9b 100644
--- a/pages/contact.vue
+++ b/pages/contact.vue
@@ -98,7 +98,7 @@ import { defineComponent } from 'vue';
 
 import useConfig from '../composables/useConfig.ts';
 import useSimpleHead from '../composables/useSimpleHead.ts';
-import { getContactLinks, getSocialLinks } from '../src/contact.js';
+import { getContactLinks, getSocialLinks } from '../src/contact.ts';
 import { groupBy } from '../src/helpers.ts';
 
 export default defineComponent({
@@ -111,14 +111,12 @@ export default defineComponent({
         useSimpleHead({
             title: translator.translate('contact.header'),
         }, translator);
+
+        const config = useConfig();
         return {
-            config: useConfig(),
-        };
-    },
-    data() {
-        return {
+            config,
             links: groupBy(
-                [...getContactLinks(this.config, this.$translator), ...getSocialLinks(this.config)],
+                [...getContactLinks(config, translator), ...getSocialLinks(config)],
                 (l) => l.group,
             ),
         };
diff --git a/src/adPlaceholders.js b/src/adPlaceholders.ts
similarity index 100%
rename from src/adPlaceholders.js
rename to src/adPlaceholders.ts
diff --git a/src/adsInternal.js b/src/adsInternal.ts
similarity index 89%
rename from src/adsInternal.js
rename to src/adsInternal.ts
index 64cb25a7a..9970d4325 100644
--- a/src/adsInternal.js
+++ b/src/adsInternal.ts
@@ -1,4 +1,14 @@
-export const adsInternal = [
+interface Ad {
+    enabled: boolean;
+    locale: string;
+    image: string;
+    placeholders: string[];
+    link: string;
+    display: string;
+    alt: string;
+}
+
+export const adsInternal: Ad[] = [
     {
         enabled: false,
         locale: 'en',
@@ -72,8 +82,8 @@ export const adsInternal = [
     // },
 ];
 
-export default (locale) => {
-    const adsInternalPerPlaceholder = {};
+export default (locale: string): Record<string, (Ad & { chance: number })[]> => {
+    const adsInternalPerPlaceholder: Record<string, (Ad & { chance: number })[]> = {};
     for (const ad of adsInternal) {
         const rightLocale = ad.locale === null || ad.locale === locale;
         if (ad.enabled === false || !rightLocale) {
diff --git a/src/contact.js b/src/contact.ts
similarity index 84%
rename from src/contact.js
rename to src/contact.ts
index 3f9567a6c..b5d496862 100644
--- a/src/contact.js
+++ b/src/contact.ts
@@ -1,4 +1,16 @@
-export const contact = {
+import type { Config, Link } from '~/locale/config.ts';
+import type { Translator } from '~/src/translator.ts';
+
+interface ContactLink extends Link {
+    group: string;
+    colour: string;
+    avatar?: string | undefined;
+}
+
+type Group = 'all' | 'calendar' | 'polish' | 'shop';
+type GroupedLinks = Partial<Record<Group, Record<string, Link>>>;
+
+export const contact: GroupedLinks = {
     all: {
         discord_community: {
             icon: 'b:discord',
@@ -40,7 +52,7 @@ export const contact = {
     },
 };
 
-export const socialLinks = {
+export const socialLinks: GroupedLinks = {
     all: {
         mastodon: {
             icon: 'mastodon',
@@ -50,7 +62,6 @@ export const socialLinks = {
         },
         bluesky: {
             icon: 'bluesky',
-            iconSet: '',
             url: 'https://bsky.app/profile/pronouns.page',
             headline: 'pronouns.page',
         },
@@ -71,7 +82,6 @@ export const socialLinks = {
         },
         bluesky: {
             icon: 'bluesky',
-            iconSet: '',
             url: 'https://bsky.app/profile/zaimki.pl',
             headline: 'zaimki.pl',
         },
@@ -110,7 +120,6 @@ export const socialLinks = {
         },
         bluesky: {
             icon: 'bluesky',
-            iconSet: '',
             url: 'https://bsky.app/profile/calendar.pronouns.page',
             headline: 'calendar.pronouns.page',
         },
@@ -131,7 +140,7 @@ export const socialLinks = {
     },
 };
 
-export const COLOURS = {
+export const COLOURS: Record<string, string> = {
     mastodon: '#3188d4',
     facebook: '#1877F2',
     linkedin: '#2867B2',
@@ -152,13 +161,13 @@ export const COLOURS = {
     workshops: '#C71585',
 };
 
-const AVATARS = {
+const AVATARS: Partial<Record<Group, string>> = {
     all: 'pronounspage.png',
     polish: 'neutratywy.png',
     calendar: 'calendarqueer.png',
 };
 
-const supportLinks = (translator) => {
+const supportLinks = (translator: Translator): GroupedLinks => {
     return {
         all: {
             bank: {
@@ -182,15 +191,12 @@ const supportLinks = (translator) => {
     };
 };
 
-function* getLink(links, group) {
+function* getLink(links: GroupedLinks, group: Group): Generator<ContactLink> {
     const featureLinks = links[group] || {};
-    for (const key in featureLinks) {
-        if (!featureLinks.hasOwnProperty(key)) {
-            continue;
-        }
-        let avatar = AVATARS[group];
-        if (featureLinks[key].url.startsWith('mailto:')) {
-            avatar = null;
+    for (const [key, link] of Object.entries(featureLinks)) {
+        let avatar: string | undefined = AVATARS[group];
+        if (link.url?.startsWith('mailto:')) {
+            avatar = undefined;
         }
         yield {
             ...featureLinks[key],
@@ -201,7 +207,7 @@ function* getLink(links, group) {
     }
 }
 
-export function* getContactLinks(config, translator) {
+export function* getContactLinks(config: Config, translator: Translator): Generator<ContactLink> {
     if (config.faq.enabled) {
         yield {
             url: `/${config.faq.route}`,
@@ -226,7 +232,7 @@ export function* getContactLinks(config, translator) {
     }
 }
 
-export function* getSocialLinks(config) {
+export function* getSocialLinks(config: Config) {
     yield * getLink(socialLinks, 'all');
     if (config.locale === 'pl') {
         yield * getLink(socialLinks, 'polish');
@@ -237,6 +243,6 @@ export function* getSocialLinks(config) {
     yield * getLink(socialLinks, 'shop');
 }
 
-export function* getSupportLinks(translator) {
+export function* getSupportLinks(translator: Translator) {
     yield * getLink(supportLinks(translator), 'all');
 }
diff --git a/src/timesheets.js b/src/timesheets.ts
similarity index 99%
rename from src/timesheets.js
rename to src/timesheets.ts
index dd2e71f58..787ed0b05 100644
--- a/src/timesheets.js
+++ b/src/timesheets.ts
@@ -26,7 +26,7 @@ export const AREAS = [
     'documentation',
     'community',
     'other',
-];
+] as const;
 
 export const MONTHS = {
     1: 'Jan',