From cac14626aab419bc6629e2109712247eb71d7f9f Mon Sep 17 00:00:00 2001 From: Benjamin Date: Fri, 13 Jun 2025 15:50:40 -0400 Subject: [PATCH 01/11] Make changes --- .gitlab-ci.yml | 10 ++-------- package.json | 2 +- pnpm-lock.yaml | 2 +- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d465e38ba..fd9aab2a4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -38,20 +38,14 @@ check: fi script: - start_section "Install Dependencies" - # temporarily replace FontAwesomePro dependency with its fake version as the CI can’t access it - # the name needs to be changed in both package.json and pnpm-lock.yaml - - 'sed -i "s/git+ssh:\/\/git@gitlab.com:Avris\/FontAwesomePro.git/git+https:\/\/gitlab.com\/Avris\/FakeFontAwesomePro.git/" package.json pnpm-lock.yaml' - # the referenced SHA needs to be additionally changed in pnpm-lock.yaml - - 'sed -i "s/git@gitlab.com+Avris\/FontAwesomePro\/f00db606f659dca78b143b7bcab5671b2cb459a8/gitlab.com\/Avris\/FakeFontAwesomePro\/0d322c775cbe9bf99da261700be30251291b51a8/" pnpm-lock.yaml' - - 'sed -i "s/resolution: {commit: f00db606f659dca78b143b7bcab5671b2cb459a8, repo: git@gitlab.com:Avris\/FontAwesomePro.git, type: git}/resolution: { tarball: https:\/\/gitlab.com\/api\/v4\/projects\/Avris%2FFakeFontAwesomePro\/repository\/archive.tar.gz?sha=0d322c775cbe9bf99da261700be30251291b51a8 }/" pnpm-lock.yaml' + - echo "https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.com" > ~/.git-credentials + - git config set --global credential.helper store - corepack enable pnpm - pnpm install || record_failure - end_section - start_section "Setup environment" - make install || record_failure - # revert the changes for the FontAwesomePro dependency only now because `make install` calls `pnpm install` - - git restore package.json pnpm-lock.yaml - end_section - start_section "Type checking" diff --git a/package.json b/package.json index d84116cef..760e6a9cb 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "@aws-sdk/client-polly": "^3.525.0", "@aws-sdk/client-s3": "^3.525.0", "@floating-ui/vue": "^1.1.5", - "@fortawesome/fontawesome-pro": "git+ssh://git@gitlab.com:Avris/FontAwesomePro.git", + "@fortawesome/fontawesome-pro": "https://gitlab.com/Avris/FontAwesomePro", "@sentry/browser": "^7.109.0", "@sentry/cli": "^2.31.0", "@sentry/node": "^7.109.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0f218089c..fbc78cd7d 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -21,7 +21,7 @@ importers: specifier: ^1.1.5 version: 1.1.5(vue@3.5.16(typescript@5.8.3)) '@fortawesome/fontawesome-pro': - specifier: git+ssh://git@gitlab.com:Avris/FontAwesomePro.git + specifier: https://gitlab.com/Avris/FontAwesomePro version: git+https://git@gitlab.com:Avris/FontAwesomePro.git#f00db606f659dca78b143b7bcab5671b2cb459a8 '@sentry/browser': specifier: ^7.109.0 From b4604e580d54bc30e718deb8f080b91790736ff2 Mon Sep 17 00:00:00 2001 From: Benjamin Date: Sat, 14 Jun 2025 14:28:11 -0400 Subject: [PATCH 02/11] try and fix git --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index fd9aab2a4..33f2e47e6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -39,7 +39,7 @@ check: script: - start_section "Install Dependencies" - echo "https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.com" > ~/.git-credentials - - git config set --global credential.helper store + - git config --global credential.helper store - corepack enable pnpm - pnpm install || record_failure - end_section From 36d63d1e1d2212a240194d434fd56241cc5dbe0b Mon Sep 17 00:00:00 2001 From: Benjamin Date: Sat, 14 Jun 2025 21:39:32 -0400 Subject: [PATCH 03/11] update readme to show the changes made and reduce un-needed steps used in the pipeline --- .gitlab-ci.yml | 9 ++------- README.md | 4 ++-- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 33f2e47e6..660899656 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -37,14 +37,10 @@ check: apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev -y fi script: - - start_section "Install Dependencies" + - start_section "Install Dependencies & Setup Environment" - echo "https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.com" > ~/.git-credentials - git config --global credential.helper store - corepack enable pnpm - - pnpm install || record_failure - - end_section - - - start_section "Setup environment" - make install || record_failure - end_section @@ -53,8 +49,7 @@ check: - end_section - start_section "Unit Tests" - - > - pnpm vitest --reporter=default --reporter=junit --outputFile=junit.xml --coverage || record_failure + - pnpm vitest --reporter=default --reporter=junit --outputFile=junit.xml --coverage || record_failure - end_section - start_section "Check linting rules" diff --git a/README.md b/README.md index ccde2b433..680dcf670 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ We're using FontAwesome Pro, so to set up a local copy without having a FA licen open `package.json` and replace ``` -"@fortawesome/fontawesome-pro": "git+ssh://git@gitlab.com:Avris/FontAwesomePro.git", +"@fortawesome/fontawesome-pro": "https://gitlab.com/Avris/FontAwesomePro", ``` with @@ -26,7 +26,7 @@ with or, for Git via HTTPS: ``` -"@fortawesome/fontawesome-pro": "git+https://git@gitlab.com/Avris/FakeFontAwesomePro.git", +"@fortawesome/fontawesome-pro": "https://gitlab.com/Avris/FakeFontAwesomePro", ``` Do not commit that change! From 00d08ed5c373d96f2ebc8d07209aa2d1f0d15b70 Mon Sep 17 00:00:00 2001 From: Benjamin Date: Sun, 15 Jun 2025 11:42:56 -0400 Subject: [PATCH 04/11] enable additional checks --- .gitlab-ci.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 660899656..0da328ca4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -203,7 +203,12 @@ deploy test/purple: ENVIRONMENT_INSTANCE: 'purple' ENVIRONMENT_DOMAIN: 'test-purple.pronouns.page' -# include: -# - template: Security/Dependency-Scanning.gitlab-ci.yml +include: + - template: Jobs/Dependency-Scanning.gitlab-ci.yml + - template: Jobs/SAST.gitlab-ci.yml + +variables: + AST_ENABLE_MR_PIPELINES: "true" + # # Pending resolution of: https://gitlab.com/PronounsPage/PronounsPage/-/merge_requests/453#note_1911466136 From 9d998162329abb40bc5d975b9fe8e071968fe28d Mon Sep 17 00:00:00 2001 From: Benjamin Date: Sun, 15 Jun 2025 11:49:09 -0400 Subject: [PATCH 05/11] (lint) --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0da328ca4..8c7188e5a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -208,7 +208,7 @@ include: - template: Jobs/SAST.gitlab-ci.yml variables: - AST_ENABLE_MR_PIPELINES: "true" + AST_ENABLE_MR_PIPELINES: 'true' # # Pending resolution of: https://gitlab.com/PronounsPage/PronounsPage/-/merge_requests/453#note_1911466136 From 85c1f2638ebdc2a7c3916394f962fc1e760c3d4c Mon Sep 17 00:00:00 2001 From: Benjamin Date: Sun, 15 Jun 2025 12:12:53 -0400 Subject: [PATCH 06/11] remove SAST --- .gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8c7188e5a..758e1b4bf 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -205,10 +205,8 @@ deploy test/purple: include: - template: Jobs/Dependency-Scanning.gitlab-ci.yml - - template: Jobs/SAST.gitlab-ci.yml variables: AST_ENABLE_MR_PIPELINES: 'true' -# # Pending resolution of: https://gitlab.com/PronounsPage/PronounsPage/-/merge_requests/453#note_1911466136 From ae4bed0c415c7c9be9fa85a98d9cc0a685908e0f Mon Sep 17 00:00:00 2001 From: Andrea Vos Date: Wed, 18 Jun 2025 21:37:15 +0200 Subject: [PATCH 07/11] (pl)(spis) fix missing 19_nie_znam --- server/express/census.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/express/census.ts b/server/express/census.ts index cc0848c58..f6ef6c024 100644 --- a/server/express/census.ts +++ b/server/express/census.ts @@ -247,7 +247,7 @@ router.get('/census/export', handleErrorAsync(async (req, res) => { for (const question of config.census.questions!) { if (question.type === 'checkbox') { const answerForAggregate: Set = new Set(); - for (const [option, _comment] of [...question.options, ...(question.optionsLast || [])]) { + for (const [option, _comment] of [...(question.optionsFirst || []), ...question.options, ...(question.optionsLast || [])]) { const checked = (answers[i.toString()] || [] as string[]).includes(option); answer[`${i}_${option}`] = checked ? 1 : ''; if (checked) { From ef67ea841aba2fc060a9585a103be3ca0345df2f Mon Sep 17 00:00:00 2001 From: Andrea Vos Date: Thu, 19 Jun 2025 08:37:09 +0200 Subject: [PATCH 08/11] (fix) broken language dropdown --- components/Dropdown.vue | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/components/Dropdown.vue b/components/Dropdown.vue index 821b18ccd..2ee2d9651 100644 --- a/components/Dropdown.vue +++ b/components/Dropdown.vue @@ -16,8 +16,10 @@ onUnmounted(() => { document.removeEventListener('click', documentClicked); }); -const documentClicked = () => { - shown.value = false; +const documentClicked = (e: MouseEvent) => { + if (e.target && !(e.target as Element).closest('.dropdown') && shown.value) { + shown.value = false; + } }; From f4b866f868d16918bde1d904f4e8116d944385ab Mon Sep 17 00:00:00 2001 From: Andrea Vos Date: Thu, 19 Jun 2025 18:36:27 +0200 Subject: [PATCH 09/11] (pl)(calendar) miastamaszerujace dwie kolumny --- server/miastamaszerujace.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/miastamaszerujace.ts b/server/miastamaszerujace.ts index 0867eab2c..93db69e13 100644 --- a/server/miastamaszerujace.ts +++ b/server/miastamaszerujace.ts @@ -28,7 +28,7 @@ const fetchEvents = async (): Promise => { // manual fixes for irregular HTML .replace(new RegExp('ref=newsfeed
', 'g'), '

') .replace(new RegExp('(.*?)', 'g'), '$1')); - const eventNodes = dom.window.document.querySelectorAll('[data-id="d4c3075"] p'); + const eventNodes = dom.window.document.querySelectorAll('[data-id="d4c3075"] p, [data-id="9cc25f4"] p'); for (const p of eventNodes) { if (p.textContent!.includes('Daty kolejnych') || p.textContent!.includes('Marsz organizowany przez grupę współpracującą') || From 0d67e18a88815f99b7b656ef1f655ec0ab719d66 Mon Sep 17 00:00:00 2001 From: Andrea Vos Date: Thu, 19 Jun 2025 18:38:29 +0200 Subject: [PATCH 10/11] (fo)(trans) --- locale/fo/translations.suml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/locale/fo/translations.suml b/locale/fo/translations.suml index 5d01a5d5a..cc3ffc43c 100644 --- a/locale/fo/translations.suml +++ b/locale/fo/translations.suml @@ -53,13 +53,8 @@ home: mission: header: 'Okkara endamál' summary: 'Vit stríða fyri frælsi, virðing og inklusjón í máli.' - freedom: > - Frælsi - – so at øll sjálv kunnu gera av - hvørji fornøvn tey føla lýsir teimum best. - respect: > - Virðing - – so at fornøvnini hjá onnur eru vird. + freedom: 'Frælsi – so at øll sjálv kunnu gera av hvørji fornøvn tey føla lýsir tey best.' + respect: 'Virðing – so at fornøvnini hjá ørðum eru vird.' inclusivity: > Inklusjón – so at tá vit tosa um ein annan persón vit ikki kenna, @@ -2009,7 +2004,7 @@ calendar: 11: '%day%. novembur' 12: '%day%. desembur' events: - pride_month: 'Pride-mánaður' + pride_month: 'Heimspride-mánaður' trans_month: 'Altjóða mánað fyri tvørkynd tilvitan' zaimki_birthday: 'Føðingardagurin hjá Pronouns.page' agender_day: 'Agender pride-dagur' @@ -2039,7 +2034,7 @@ calendar: trans_parent_day___timeDescription: 'á fyrsta sunnudag í novembur' nonbinary_week: 'Tilvitingarvika um ikki-biner' nonbinary_week___timeDescription: 'í vikuni (man-sun) rundan um 14’inda july' - polyamory_day: 'Polyamory-Dagur' + polyamory_day: 'Fleiralskhuga-dagur' homophobia_sport: 'Altjóðadagur ímóti homofobi í ítrótti' gay_uncles_day: 'Dagur teirra samkyndu gubbar' gay_uncles_day___timeDescription: 'á næsta sunnudag í august' From 6923f8ba44d856610bcfc29c4004f8f206e1d7b2 Mon Sep 17 00:00:00 2001 From: Benjamin Date: Thu, 19 Jun 2025 18:01:04 -0400 Subject: [PATCH 11/11] (ci) Fix Dependency Scanning --- .gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 758e1b4bf..acf099c9d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -207,6 +207,6 @@ include: - template: Jobs/Dependency-Scanning.gitlab-ci.yml variables: - AST_ENABLE_MR_PIPELINES: 'true' - -# Pending resolution of: https://gitlab.com/PronounsPage/PronounsPage/-/merge_requests/453#note_1911466136 + AST_ENABLE_MR_PIPELINES: true + DS_EXCLUDED_ANALYZERS: gemnasium-python + DS_MAX_DEPTH: 4