From 052316ba25c86d5dcc870cd5b4c045ea67110562 Mon Sep 17 00:00:00 2001 From: Fijxu Date: Sun, 30 Mar 2025 00:12:19 -0300 Subject: [PATCH] cmd/containerbuild: use TrimSuffix instead of TrimRight (#157) Using TrimRight will remove all characters from `*dockerRepo` from right to left that match a character contained on `"/"+filepath.Base(*dockerRepo)` (the cutset) until it doesn't matches anymore. So for example, if `dockerRepo` is `example.com/fijxu/anubis`, and `"/"+filepath.Base(*dockerRepo)` is `/anubis`, it will remove `u/anubis` and not just `/anubis` from `dockerRepo` because `u` is a character inside the cutoff. --- cmd/containerbuild/main.go | 2 +- docs/docs/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/containerbuild/main.go b/cmd/containerbuild/main.go index 18e879c..8d34a3a 100644 --- a/cmd/containerbuild/main.go +++ b/cmd/containerbuild/main.go @@ -30,7 +30,7 @@ func main() { internal.InitSlog(*slogLevel) - koDockerRepo := strings.TrimRight(*dockerRepo, "/"+filepath.Base(*dockerRepo)) + koDockerRepo := strings.TrimSuffix(*dockerRepo, "/"+filepath.Base(*dockerRepo)) if *githubEventName == "pull_request" && *pullRequestID != -1 { *dockerRepo = fmt.Sprintf("ttl.sh/techaro/pr-%d/anubis", *pullRequestID) diff --git a/docs/docs/CHANGELOG.md b/docs/docs/CHANGELOG.md index e95e0c8..2ddda01 100644 --- a/docs/docs/CHANGELOG.md +++ b/docs/docs/CHANGELOG.md @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Developer documentation has been added to the docs site - Show more errors when some predictable challenge page errors happen ([#150](https://github.com/TecharoHQ/anubis/issues/150)) - Verification page now shows hash rate and a progress bar for completion probability. +- Use `TrimSuffix` instead of `TrimRight` on containerbuild ## v1.15.0