From 43b8a9257a50fc7346cef2031d465c88f47307bc Mon Sep 17 00:00:00 2001 From: Xe Iaso Date: Tue, 1 Apr 2025 17:54:54 -0400 Subject: [PATCH] lib: minimize the amount and type of data collected Signed-off-by: Xe Iaso --- docs/docs/CHANGELOG.md | 1 + lib/anubis.go | 19 +++---------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/docs/docs/CHANGELOG.md b/docs/docs/CHANGELOG.md index b7e1336..d512c73 100644 --- a/docs/docs/CHANGELOG.md +++ b/docs/docs/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +- Minimize the amount of data logged when users pass, fail, or otherwise interact with Anubis - Added a periodic cleanup routine for the decaymap that removes expired entries, ensuring stale data is properly pruned. - Added a no-store Cache-Control header to the challenge page - Hide the directory listings for Anubis' internal static content diff --git a/lib/anubis.go b/lib/anubis.go index 732d2c3..bda8f0e 100644 --- a/lib/anubis.go +++ b/lib/anubis.go @@ -174,14 +174,7 @@ func (s *Server) challengeFor(r *http.Request, difficulty int) string { } func (s *Server) MaybeReverseProxy(w http.ResponseWriter, r *http.Request) { - lg := slog.With( - "user_agent", r.UserAgent(), - "accept_language", r.Header.Get("Accept-Language"), - "priority", r.Header.Get("Priority"), - "x-forwarded-for", - r.Header.Get("X-Forwarded-For"), - "x-real-ip", r.Header.Get("X-Real-Ip"), - ) + lg := slog.With("user_agent", r.UserAgent()) cr, rule, err := s.check(r) if err != nil { @@ -344,7 +337,7 @@ func (s *Server) RenderBench(w http.ResponseWriter, r *http.Request) { } func (s *Server) MakeChallenge(w http.ResponseWriter, r *http.Request) { - lg := slog.With("user_agent", r.UserAgent(), "accept_language", r.Header.Get("Accept-Language"), "priority", r.Header.Get("Priority"), "x-forwarded-for", r.Header.Get("X-Forwarded-For"), "x-real-ip", r.Header.Get("X-Real-Ip")) + lg := slog.With("user_agent", r.UserAgent()) cr, rule, err := s.check(r) if err != nil { @@ -372,13 +365,7 @@ func (s *Server) MakeChallenge(w http.ResponseWriter, r *http.Request) { } func (s *Server) PassChallenge(w http.ResponseWriter, r *http.Request) { - lg := slog.With( - "user_agent", r.UserAgent(), - "accept_language", r.Header.Get("Accept-Language"), - "priority", r.Header.Get("Priority"), - "x-forwarded-for", r.Header.Get("X-Forwarded-For"), - "x-real-ip", r.Header.Get("X-Real-Ip"), - ) + lg := slog.With("user_agent", r.UserAgent()) cr, rule, err := s.check(r) if err != nil {