Get Windows return code in wait()

Currently, wait() returns 0 on windows regardless
of the actual return code of processes.
This commit is contained in:
Haowen Liu 2025-04-20 17:44:55 -04:00
parent 3afe581c1f
commit 50db2113ff
No known key found for this signature in database
GPG Key ID: F65B4067F3357C78

View File

@ -1408,7 +1408,12 @@ inline int Popen::wait() noexcept(false)
#ifdef __USING_WINDOWS__
int ret = WaitForSingleObject(process_handle_, INFINITE);
return 0;
DWORD dretcode_;
if (FALSE == GetExitCodeProcess(process_handle_, &dretcode_))
throw OSError("Failed during call to GetExitCodeProcess", 0);
return (int)dretcode_;
#else
int ret, status;
std::tie(ret, status) = util::wait_for_child_exit(pid());