TheCloud/cpp-subprocess
1
0
Fork 0
mirror of https://github.com/arun11299/cpp-subprocess.git synced 2025-08-05 04:46:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

windows: Don't add an extra whitespace at end of Windows command line (#119)

Browse Source 
The windows code adds an unnecessary extra space to the command line.
This can cause subtle issues, so avoid it.
This commit is contained in:
Mara van der Laan 2025-05-20 12:42:18 +02:00 committed by GitHub
parent f6232a7f26
commit 777cfa77d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cpp-subprocess/subprocess.hpp
View File

@ -1541,11 +1541,16 @@ inline void Popen::execute_process() noexcept(false)
std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter; std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter;
std::wstring argument; std::wstring argument;
std::wstring command_line; std::wstring command_line;
bool first_arg = true;
for (auto arg : this->vargs_) { for (auto arg : this->vargs_) {
if (!first_arg) {
command_line += L" ";
} else {
first_arg = false;
}
argument = converter.from_bytes(arg); argument = converter.from_bytes(arg);
util::quote_argument(argument, command_line, false); util::quote_argument(argument, command_line, false);
command_line += L" ";
} }
// CreateProcessW can modify szCmdLine so we allocate needed memory // CreateProcessW can modify szCmdLine so we allocate needed memory