TheCloud/cpp-subprocess
1
0
Fork 0
mirror of https://github.com/arun11299/cpp-subprocess.git synced 2025-08-05 12:56:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace throw with noexcept for C17 compatibility (#17)

Browse Source 
C++11 started to deprecate the use of throw function identifiers.  In
C++17, this header no longer compiles due to the deprecation.

Signed-off-by: Ben Dang <me@bdang.it>
This commit is contained in:
Ben Dang 2018-10-08 00:15:10 -07:00 committed by Arun Muralidharan
parent a90174cf5c
commit 899e9b997d
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
subprocess.hpp
View File

@ -217,7 +217,7 @@ namespace util
* Second element is the write descriptor of pipe. * Second element is the write descriptor of pipe.
*/ */
static inline static inline
std::pair<int, int> pipe_cloexec() throw (OSError) std::pair<int, int> pipe_cloexec() noexcept(false)
{ {
int pipe_fds[2]; int pipe_fds[2];
int res = pipe(pipe_fds); int res = pipe(pipe_fds);
@ -965,15 +965,15 @@ public:
if (!defer_process_start_) execute_process(); if (!defer_process_start_) execute_process();
} }
void start_process() throw (CalledProcessError, OSError); void start_process() noexcept(false);
int pid() const noexcept { return child_pid_; } int pid() const noexcept { return child_pid_; }
int retcode() const noexcept { return retcode_; } int retcode() const noexcept { return retcode_; }
int wait() throw(OSError); int wait() noexcept(false);
int poll() throw(OSError); int poll() noexcept(false);
// Does not fail, Caller is expected to recheck the // Does not fail, Caller is expected to recheck the
// status with a call to poll() // status with a call to poll()
@ -1017,7 +1017,7 @@ private:
void init_args(F&& farg, Args&&... args); void init_args(F&& farg, Args&&... args);
void init_args(); void init_args();
void populate_c_argv(); void populate_c_argv();
void execute_process() throw (CalledProcessError, OSError); void execute_process() noexcept(false);
private: private:
detail::Streams stream_; detail::Streams stream_;
@ -1066,7 +1066,7 @@ inline void Popen::populate_c_argv()
cargv_.push_back(nullptr); cargv_.push_back(nullptr);
} }
inline void Popen::start_process() throw (CalledProcessError, OSError) inline void Popen::start_process() noexcept(false)
{ {
// The process was started/tried to be started // The process was started/tried to be started
// in the constructor itself. // in the constructor itself.
@ -1080,7 +1080,7 @@ inline void Popen::start_process() throw (CalledProcessError, OSError)
execute_process(); execute_process();
} }
inline int Popen::wait() throw (OSError) inline int Popen::wait() noexcept(false)
{ {
int ret, status; int ret, status;
std::tie(ret, status) = util::wait_for_child_exit(pid()); std::tie(ret, status) = util::wait_for_child_exit(pid());
@ -1095,7 +1095,7 @@ inline int Popen::wait() throw (OSError)
return 0; return 0;
} }
inline int Popen::poll() throw (OSError) inline int Popen::poll() noexcept(false)
{ {
int status; int status;
if (!child_created_) return -1; // TODO: ?? if (!child_created_) return -1; // TODO: ??
@ -1137,7 +1137,7 @@ inline void Popen::kill(int sig_num)
} }
inline void Popen::execute_process() throw (CalledProcessError, OSError) inline void Popen::execute_process() noexcept(false)
{ {
int err_rd_pipe, err_wr_pipe; int err_rd_pipe, err_wr_pipe;
std::tie(err_rd_pipe, err_wr_pipe) = util::pipe_cloexec(); std::tie(err_rd_pipe, err_wr_pipe) = util::pipe_cloexec();